murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683434613
> So, I have two main problems with this PR I consider this progress 😃 > 1. Using `solr.xml` There's no other place to set default config (not hard code!) for which placement plugin to use. `solr.xml` is such a place, is used in that way for other values so makes perfectly sense here. Previous Autoscaling framework used `solr.xml` for config (for autoscaling trigger). It did not use it for the preferences and policy because these were collection specific, but you suggested placement plugins be a cluster level config so I followed that route instead. > 2. having 2 interfaces for each property Untrue. There's only one interface, for the value. Keys all share the same interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
