murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without creating so many different interfaces It's easy to have a single `PropertyValue` interface with all possible getter methods and have all but one return an empty optional. I don't see how that's better. Also I don't want to assume the plugin code knows which node a request should be sent to (i.e. passing the node to `onNode()`). It does know the node for most requests but not all. When requesting data about a given shard or replica for example (say number of docs, or index size), it is not the role of the plugin to find out which node that replica is on to route the request there. I prefer the behind the scenes implementation to do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
