Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955075860 ## core/src/test/java/org/apache/iceberg/avro/TestSchemaConversions.java: ## @@ -76,7 +78,8 @@ public void testPrimitiveTypes() { Schema.createFixed("fixe

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] update site to include iceberg summit link [iceberg]

Fokko commented on code in PR #12256: URL: https://github.com/apache/iceberg/pull/12256#discussion_r1955078240 ## site/overrides/home.html: ## @@ -36,9 +36,9 @@ Apache Iceberg™ The open table format for analytic datasets. -https:

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] feat(catalog/rest): Add support for view related operations [iceberg-go]

dttung2905 commented on code in PR #290: URL: https://github.com/apache/iceberg-go/pull/290#discussion_r195513 ## catalog/rest/rest.go: ## @@ -989,3 +992,95 @@ func (r *Catalog) CheckTableExists(ctx context.Context, identifier table.Identif } return true, ni

[PR] Added description of CLI usage in README [iceberg-go]

subkanthi opened a new pull request, #301: URL: https://github.com/apache/iceberg-go/pull/301 Added description of CLI usage in README similar to pyiceberg. https://py.iceberg.apache.org/cli/ -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add table upsert support [iceberg-python]

mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657806614 > Great work @mattmartin14 👏🏻 👏🏻 > > If I'm not mistaken this is your first PR merged in any open source project correct? > > Not a bad first feature! Mine was ad

Re: [I] set tblproperties, spark action expireSnapshots is not work. [iceberg]

RussellSpitzer commented on issue #12078: URL: https://github.com/apache/iceberg/issues/12078#issuecomment-2657726189 Ah so you are setting a Table Property in Hive. But then running Expire Snapshots in Spark but Spark isn't using the table properties that you set. Can you check the u

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955206561 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -616,8 +616,8 @@ public T map(Types.MapType map, T keyResult, T valueResult) { return null;

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955196818 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier keyResult, Supplier valueResult)

Re: [PR] Add table upsert support [iceberg-python]

bitsondatadev commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657742066 Great work @mattmartin14 👏🏻 👏🏻 If I'm not mistaken this is your first PR merged in any open source project correct? Not a bad first feature! Mine was adding [ar

Re: [PR] CORE: return false when view exists endpoint isn't supported [iceberg]

rdblue commented on code in PR #12259: URL: https://github.com/apache/iceberg/pull/12259#discussion_r1955238348 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1239,7 +1239,9 @@ public List listViews(SessionContext context, Namespace namespa @

Re: [PR] Core,Api: Add overwrite option when register external table to catalog [iceberg]

dramaticlly commented on code in PR #12228: URL: https://github.com/apache/iceberg/pull/12228#discussion_r1955046373 ## api/src/main/java/org/apache/iceberg/catalog/Catalog.java: ## @@ -344,7 +344,23 @@ default void invalidateTable(TableIdentifier identifier) {} * @throws Al

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1954884816 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -404,8 +408,31 @@ private void validateAndIn

Re: [PR] Core: Fix divide by zero when adjust split size [iceberg]

RussellSpitzer commented on code in PR #12201: URL: https://github.com/apache/iceberg/pull/12201#discussion_r1954977506 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -57,7 +60,10 @@ protected static Object[][] parameters() { {

Re: [PR] Core: Fix divide by zero when adjust split size [iceberg]

RussellSpitzer merged PR #12201: URL: https://github.com/apache/iceberg/pull/12201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Fix divide by zero when adjust split size [iceberg]

RussellSpitzer commented on PR #12201: URL: https://github.com/apache/iceberg/pull/12201#issuecomment-2657564295 Thanks @hantangwangd for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2657587163 @Fokko Thanks for the review. I got a bit mixed up with the logic with only nulls vs may contain null 😆. Should be good now -- This is an automated message from the Apache Git Se

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955155159 ## core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java: ## @@ -187,6 +187,18 @@ public Schema map(Types.MapType map, Schema keySchema, Schema valueSchema) {

Re: [PR] feat(catalog/glue): Use awscfg from catalog creation when loading data from glue [iceberg-go]

zeroshade merged PR #286: URL: https://github.com/apache/iceberg-go/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

smaheshwar-pltr commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955183564 ## mkdocs/docs/configuration.md: ## @@ -203,12 +204,15 @@ PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pya ## Locatio

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

smaheshwar-pltr commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955183564 ## mkdocs/docs/configuration.md: ## @@ -203,12 +204,15 @@ PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pya ## Locatio

[PR] Spark: Remove unused PruneColumnsWithReordering class [iceberg]

rdblue opened a new pull request, #12258: URL: https://github.com/apache/iceberg/pull/12258 This class isn't used. If I remember correctly, the purpose of `PruneColumnsWithReordering` was to produce a schema that matched the requested Spark schema before DSv2 could add a projection to reord

Re: [PR] Add table upsert support [iceberg-python]

Fokko commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657684518 @mattmartin14 Yes, please go ahead. Thanks everyone for driving this, @mattmartin14 in particular! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Add table upsert support [iceberg-python]

Fokko merged PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Add table upsert support [iceberg-python]

mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657667851 > This looks great! Thanks again @mattmartin14 > > Regarding @bitsondatadev's comment, when you do a squash and commit, you'll see multiple authors, example can be found

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2657686000 Final stage of this PR was moved to new [PR #1660](https://github.com/apache/iceberg-python/pull/1660) due to some infrastructure challenges on my end. Closing this one now.

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

mattmartin14 closed pull request #1534: Feature: MERGE/Upsert Support URL: https://github.com/apache/iceberg-python/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955196818 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier keyResult, Supplier valueResult)

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955196818 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier keyResult, Supplier valueResult)

[PR] CORE: return false when view exists endpoint isn't supported [iceberg]

danielcweeks opened a new pull request, #12259: URL: https://github.com/apache/iceberg/pull/12259 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Core: add variant type support [iceberg]

rdblue commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955196818 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier keyResult, Supplier valueResult)

Re: [PR] Add table upsert support [iceberg-python]

mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657682312 @Fokko @kevinjqliu - should I go ahead and close the old PR now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] CORE: return false when view exists endpoint isn't supported [iceberg]

danielcweeks commented on PR #12259: URL: https://github.com/apache/iceberg/pull/12259#issuecomment-2657694224 (cc @ajreid21) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Metadata location fallback [iceberg-python]

IsaacWarren commented on PR #1658: URL: https://github.com/apache/iceberg-python/pull/1658#issuecomment-2657153561 It was a create table transaction so it makes sense it was null. I think I was confused that metadata-location and table_metadata.location were equivalent but on further readin

Re: [PR] update site to include iceberg summit link [iceberg]

RussellSpitzer commented on code in PR #12256: URL: https://github.com/apache/iceberg/pull/12256#discussion_r1955059867 ## site/overrides/home.html: ## @@ -36,9 +36,9 @@ Apache Iceberg™ The open table format for analytic datasets. -

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955061076 ## core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java: ## @@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() { .as("Result o

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955059718 ## core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java: ## @@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() { .as("Result o

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955058185 ## core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java: ## @@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() { .as("Result o

[PR] Add table upsert support [iceberg-python]

kevinjqliu opened a new pull request, #1660: URL: https://github.com/apache/iceberg-python/pull/1660 Closes #402 This PR adds the `upsert` function to Table and supports the following upsert operations: - when matched update all - when not matched insert all This PR is a rema

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

smaheshwar-pltr commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955044524 ## pyiceberg/table/locations.py: ## @@ -64,6 +71,35 @@ def new_data_location(self, data_file_name: str, partition_key: Optional[Partiti str

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Add table upsert support [iceberg-python]

kevinjqliu commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657451094 cc reviewers from the other PR (@Fokko / @corleyma / @tscottcoombes1 / @marcoaanogueira) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955046563 ## core/src/main/java/org/apache/iceberg/avro/Variant.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955051131 ## core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java: ## @@ -219,6 +219,13 @@ public static boolean isKeyValueSchema(Schema schema) { return schema.g

Re: [PR] Add Variant custom logical type for Avro [iceberg]

rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955053312 ## core/src/main/java/org/apache/iceberg/avro/Variant.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] Core: Add InternalData read and write builders [iceberg]

rdblue commented on code in PR #12060: URL: https://github.com/apache/iceberg/pull/12060#discussion_r1955144135 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -278,37 +277,41 @@ static Types.StructType fileType(Types.StructType partitionType) { DataFil

Re: [I] Add properties support for HadoopTables.load() [iceberg]

RussellSpitzer commented on issue #12251: URL: https://github.com/apache/iceberg/issues/12251#issuecomment-2657124263 HadoopTables isn't a catalog though? I always thought of it more as a low level method for loading up an Iceberg table without a catalog being present. Can you explain the u

Re: [PR] Metadata location fallback [iceberg-python]

IsaacWarren closed pull request #1658: Metadata location fallback URL: https://github.com/apache/iceberg-python/pull/1658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

ajantha-bhat commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1949666773 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Excep

Re: [PR] Core: Fix divide by zero when adjust split size [iceberg]

RussellSpitzer commented on code in PR #12201: URL: https://github.com/apache/iceberg/pull/12201#discussion_r1954976117 ## core/src/main/java/org/apache/iceberg/util/TableScanUtil.java: ## @@ -233,6 +233,8 @@ public static List mergeTasks(List tasks) { } public static

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

jonathanc-n commented on code in PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#discussion_r1955105071 ## crates/iceberg/src/expr/visitors/strict_metrics_evaluator.rs: ## @@ -0,0 +1,1854 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] API, Core: Support default values in UpdateSchema [iceberg]

rdblue merged PR #12211: URL: https://github.com/apache/iceberg/pull/12211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] update site to include iceberg summit link [iceberg]

RussellSpitzer commented on PR #12256: URL: https://github.com/apache/iceberg/pull/12256#issuecomment-2657549185 Thanks @danicafine ! Thanks @Fokko for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] API, Core: Support default values in UpdateSchema [iceberg]

rdblue commented on PR #12211: URL: https://github.com/apache/iceberg/pull/12211#issuecomment-2657547085 Merged. Thanks for reviewing, @Fokko, @danielcweeks, and @aokolnychyi! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

geruh commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955110870 ## pyiceberg/table/locations.py: ## @@ -64,6 +71,35 @@ def new_data_location(self, data_file_name: str, partition_key: Optional[Partiti str: A fully-

Re: [PR] Core: Add InternalData read and write builders [iceberg]

rdblue commented on PR #12060: URL: https://github.com/apache/iceberg/pull/12060#issuecomment-2657544978 Merging this now that the 1.8.0 vote has passed. Thanks for reviewing, everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Core: BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

deniskuzZ commented on code in PR #12137: URL: https://github.com/apache/iceberg/pull/12137#discussion_r1955044758 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution() throws Exceptio

Re: [PR] Core: Add InternalData read and write builders [iceberg]

rdblue merged PR #12060: URL: https://github.com/apache/iceberg/pull/12060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] update site to include iceberg summit link [iceberg]

RussellSpitzer merged PR #12256: URL: https://github.com/apache/iceberg/pull/12256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

[PR] Core: use ReachableFileCleanup when table has discontinuous snapshots [iceberg]

MavsLee opened a new pull request, #12261: URL: https://github.com/apache/iceberg/pull/12261 This change is to fix fixes issue: #12200 . by updating `RemoveSnapshots.cleanExpiredSnapshots()` to use `ReachableFileCleanup` strategy to clean up expired files when table has discontinuous sn

Re: [PR] S3: Disable strong integrity checksums [iceberg]

amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955593603 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) {

Re: [PR] Manifest list encryption [iceberg]

gumartinm commented on PR #7770: URL: https://github.com/apache/iceberg/pull/7770#issuecomment-2657946677 If you need help with this pull request @ggershinsky, perhaps I could help you. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Apply residuals when reading a table [iceberg-python]

corleyma commented on code in PR #1654: URL: https://github.com/apache/iceberg-python/pull/1654#discussion_r1955401755 ## pyiceberg/io/pyarrow.py: ## @@ -1342,9 +1342,8 @@ def _get_column_projection_values( def _task_to_record_batches( fs: FileSystem, task: FileScanTa

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955404930 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java: ## @@ -458,7 +502,7 @@ public ReadLimit getDefaultReadLimit() {

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

kevinjqliu commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955405522 ## mkdocs/docs/configuration.md: ## @@ -203,12 +204,15 @@ PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pya ## Location Pro

Re: [PR] Add support for `write.metadata.path` [iceberg-python]

kevinjqliu commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955405522 ## mkdocs/docs/configuration.md: ## @@ -203,12 +204,15 @@ PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pya ## Location Pro

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955407420 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java: ## @@ -206,6 +220,18 @@ public void testReadStreamOnIcebergTableW

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2658021202 @singhpk234 @jackye1995 @RussellSpitzer this is a small fix; can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Support bucket transform on multiple data columns [iceberg]

github-actions[bot] commented on issue #5626: URL: https://github.com/apache/iceberg/issues/5626#issuecomment-2657973302 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive: Add Hive 4 support and remove Hive runtime [iceberg]

github-actions[bot] closed pull request #11750: Hive: Add Hive 4 support and remove Hive runtime URL: https://github.com/apache/iceberg/pull/11750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Flink: Maintenance - RewriteDataFiles [iceberg]

github-actions[bot] commented on PR #11497: URL: https://github.com/apache/iceberg/pull/11497#issuecomment-2657973451 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] backport #11301(rowconverter) to Flink 1.19 and 1.18 [iceberg]

github-actions[bot] commented on PR #11826: URL: https://github.com/apache/iceberg/pull/11826#issuecomment-2657973561 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] backport #11301(rowconverter) to Flink 1.19 and 1.18 [iceberg]

github-actions[bot] closed pull request #11826: backport #11301(rowconverter) to Flink 1.19 and 1.18 URL: https://github.com/apache/iceberg/pull/11826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Docs: Add clear indicators for required fields in Spark syntax on CREATE TABLE. [iceberg]

github-actions[bot] commented on issue #9545: URL: https://github.com/apache/iceberg/issues/9545#issuecomment-265797 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive: Add Hive 4 support and remove Hive runtime [iceberg]

github-actions[bot] commented on PR #11750: URL: https://github.com/apache/iceberg/pull/11750#issuecomment-2657973521 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

amogh-jahagirdar commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1955585866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWrit

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

amogh-jahagirdar commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1955585866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWrit

Re: [PR] CORE: return false when view exists endpoint isn't supported [iceberg]

nastra commented on code in PR #12259: URL: https://github.com/apache/iceberg/pull/12259#discussion_r1955661232 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1239,7 +1239,9 @@ public List listViews(SessionContext context, Namespace namespa @

<    1   2