kevinjqliu commented on code in PR #1642:
URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955405522


##########
mkdocs/docs/configuration.md:
##########
@@ -203,12 +204,15 @@ PyIceberg uses 
[S3FileSystem](https://arrow.apache.org/docs/python/generated/pya
 
 ## Location Providers
 
-Apache Iceberg uses the concept of a `LocationProvider` to manage file paths 
for a table's data. In PyIceberg, the
+Apache Iceberg uses the concept of a `LocationProvider` to manage file paths 
for a table's data and metadata files. In PyIceberg, the
 `LocationProvider` module is designed to be pluggable, allowing customization 
for specific use cases. The
 `LocationProvider` for a table can be specified through table properties.
 
-PyIceberg defaults to the 
[`ObjectStoreLocationProvider`](configuration.md#object-store-location-provider),
 which generates
-file paths that are optimized for object storage.
+While data files can leverage provider-specific optimizations, metadata files 
always follow a simple path configuration. Regardless of
+the `LocationProvider` used, metadata files are written to the path specified 
by the [`write.metadata.path` table configuration](#write-options) table 
property.

Review Comment:
   based on talking to myself 
[here](https://github.com/apache/iceberg-python/pull/1642/files#r1955395642)
   
   how about something like,
   ```suggestion
   Both data file and metadata file locations can be customized by configuring 
the table properties [write.data.path and write.metadata.path](#write-options), 
respectively.
   
   For more granular control, you can override the `LocationProvider`'s 
`new_data_location` and `new_metadata_location` methods to define custom logic 
for generating file paths.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to