amogh-jahagirdar commented on code in PR #12250:
URL: https://github.com/apache/iceberg/pull/12250#discussion_r1955585866


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -213,45 +217,61 @@ static class PositionDeletesWriterFactory implements 
DataWriterFactory {
       this.writeProperties = writeProperties;
     }
 
+    private Table underlyingTable(Table table) {

Review Comment:
   Yeah I'm a bit confused why we couldn't just leverage the existing table 
broadcast? If it's a different type, does broadcasting the underlying table 
work instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to