rdblue commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955053312
########## core/src/main/java/org/apache/iceberg/avro/Variant.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.avro; + +import org.apache.avro.LogicalType; +import org.apache.avro.Schema; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +public class Variant extends LogicalType { + static final String NAME = "variant"; + private static final Variant INSTANCE = new Variant(); + + static Variant get() { + return INSTANCE; + } + + private Variant() { + super(NAME); + } + + @Override + public void validate(Schema schema) { + super.validate(schema); + Preconditions.checkArgument( + schema.getType() == Schema.Type.RECORD, + "Invalid type for variant, must be a record: %s", + schema); + Preconditions.checkArgument( + AvroSchemaUtil.isVariantSchema(schema), "Invalid variant record: %s", schema); Review Comment: I think this should check that the fields are binary since it is validating that the schema can be used to store variant data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
