RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1954976117
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -233,6 +233,8 @@ public static <T extends ScanTask> List<T>
mergeTasks(List<T> tasks) {
}
public static long adjustSplitSize(long scanSize, int parallelism, long
splitSize) {
+ Preconditions.checkArgument(splitSize > 0, "Split size must be > 0: %s",
splitSize);
+
Review Comment:
This is a public api, so anyone can call it. We probably should still guard
unless we are ok with it throwing divide by 0 exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
