amogh-jahagirdar commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955593603
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java:
##########
@@ -149,4 +151,10 @@ static void configurePermission(
Function<ObjectCannedACL, S3Request.Builder> aclSetter) {
aclSetter.apply(s3FileIOProperties.acl());
}
+
+ // TODO Remove me once all of the S3-compatible storage support strong
integrity checks
+ @SuppressWarnings("deprecation")
+ static AwsRequestOverrideConfiguration disableStrongIntegrityChecksums() {
+ return
AwsRequestOverrideConfiguration.builder().signer(AwsS3V4Signer.create()).build();
Review Comment:
I'm not sure this is the right way to disable it? Feels like this is just a
side effect of setting a new signer but I don't think we want that.
https://github.com/aws/aws-sdk-java-v2/issues/5848#issuecomment-2627909526
https://github.com/aws/aws-sdk-java-v2/blob/468d10445765c26deeaa451d34c446b6f0616f6b/services/s3/src/it/java/software/amazon/awssdk/services/s3/checksum/HttpChecksumIntegrationTest.java#L428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
