ajantha-bhat commented on code in PR #12137:
URL: https://github.com/apache/iceberg/pull/12137#discussion_r1949666773
##########
core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java:
##########
@@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution()
throws Exception {
snapshot2.snapshotId()));
}
- private static PartitionData partitionData(Types.StructType partitionType,
String c2, String c3) {
- PartitionData partitionData = new PartitionData(partitionType);
- partitionData.set(0, c2);
- partitionData.set(1, c3);
- return partitionData;
+ @org.junit.Test
Review Comment:
Should use junit5 like other tests. (Used wrong annotation?)
I don't think the tests are running right now.
So, please fix it and I will try to understand the test case.
The original intention is to store the unified tuple as the key itself. So,
it can handle all the partition evolution. So, from the test I am not yet clear
what was expected and what went wrong easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
