nastra commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1816130291
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nastra commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1816127090
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -225,6 +225,13 @@ public class S3FileIOProperties implements Serializable {
*/
pub
manuzhang commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814618649
##
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##
@@ -68,6 +68,7 @@ public class IcebergPigInputFormat extends
InputFormat {
private Li
bknbkn opened a new pull request, #11387:
URL: https://github.com/apache/iceberg/pull/11387
fix #11314
In the previous code, each spec reads the latest schema. After deleting the
corresponding field, the historical spec cannot find the corresponding field in
the current schema, and
ajantha-bhat commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814837238
##
pig/src/main/java/org/apache/iceberg/pig/PigParquetReader.java:
##
@@ -60,9 +60,20 @@
import org.apache.pig.data.DataByteArray;
import org.apache.pig.data.T
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815446522
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
sdd opened a new issue, #679:
URL: https://github.com/apache/iceberg-rust/issues/679
Submitting a fix for this now.
See
https://github.com/apache/iceberg-rust/actions/runs/11504666519/job/32024660546?pr=652
```
error: use of deprecated method `opendal::Operator::is_exist`: r
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815741890
##
format/spec.md:
##
@@ -178,6 +178,11 @@ A **`list`** is a collection of values with some element
type. The element field
A **`map`** is a collection of key-valu
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815802178
##
api/src/main/java/org/apache/iceberg/VariantLike.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributo
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815723294
##
format/spec.md:
##
@@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following
behavior: `-NaN` < `
A data or delete file is associated with
nastra commented on PR #11380:
URL: https://github.com/apache/iceberg/pull/11380#issuecomment-2435580112
please also update all of the yaml files for GH actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
RussellSpitzer commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1815720005
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java:
##
@@ -84,11 +93,18 @@
import org.apache.kafka.connect.
rdblue commented on code in PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#discussion_r1815781801
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -138,20 +138,16 @@ protected boolean isCaseSensitive() {
}
protected PartitionSpec
amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815720545
##
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##
@@ -595,18 +601,18 @@ public void testDeleteDataFileWithDeleteFile() {
assertThat(deleteS
amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815723992
##
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##
@@ -323,11 +345,15 @@ private ManifestFile filterManifest(Schema tableSchema,
Manife
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815515307
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
omkenge commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2436339798
HI @sungwy , I added test for list view you can verify
and answer to @kevinjqliu, sure I will work on your suggestion
--
This is an automated message from the Apache Git Servic
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815793743
##
api/src/main/java/org/apache/iceberg/types/Type.java:
##
@@ -45,7 +46,8 @@ enum TypeID {
DECIMAL(BigDecimal.class),
STRUCT(StructLike.class),
LIST(Li
singhpk234 commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815553135
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #10995:
URL: https://github.com/apache/iceberg/pull/10995#discussion_r1815163457
##
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##
@@ -252,11 +252,36 @@ public void testFailure() {
assertThat(new File(newManifest.path())).doesNo
findepi commented on code in PR #11238:
URL: https://github.com/apache/iceberg/pull/11238#discussion_r1816204620
##
format/puffin-spec.md:
##
@@ -123,6 +123,49 @@ The blob metadata for this blob may include following
properties:
- `ndv`: estimate of number of distinct values
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815510702
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
findepi commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2437181487
@jbonofre there is a conflict, you may want to resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
adutra commented on PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#issuecomment-2436304310
@danielcweeks it took me some time to address your comments but this is
ready for a second round of review whenever you have time.
Apart from polishing commits, two major changes s
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815721928
##
format/spec.md:
##
@@ -357,16 +362,16 @@ Partition field IDs must be reused if an existing
partition spec contains an equ
### Partition Transforms
-| Transfor
Xuanwo commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2437301516
Thank you @sundy-li for this work, also thanks @liurenjie1024's review and
@sdd for fixing CI, we are fine to merge now.
--
This is an automated message from the Apache Git Service.
T
liurenjie1024 closed issue #676: bug: TableScanBuilder should take care of
empty projections
URL: https://github.com/apache/iceberg-rust/issues/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
RussellSpitzer commented on issue #10378:
URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2438002646
@jbonofre Did you want to work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
amogh-jahagirdar commented on PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#issuecomment-2437961434
The change looks good to me, I'll go ahead and merge since @rdblue comment
was addressed. Thanks for the improvement @nastra , and for the reviews
@singhpk234 @rdblue!
--
T
nastra closed pull request #11389: AWS: Refresh vended credentials
URL: https://github.com/apache/iceberg/pull/11389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
RussellSpitzer commented on PR #11157:
URL: https://github.com/apache/iceberg/pull/11157#issuecomment-2437997523
> `ExecutorService` is used to parallelize reading files to build manifests
on the Spark executors for Spark table migration procedures (`add_files`,
`migrate`, `snapshot`).
RussellSpitzer commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2438030667
LGTM. @danielcweeks This adds in that test I was looking for where URI would
fail, although looks like we have a bug in the current implementation anyway.
--
This is an autom
manuzhang commented on PR #11157:
URL: https://github.com/apache/iceberg/pull/11157#issuecomment-2438088192
Yes, it's used in `listPartitions` while the title was not accurate.
Migrating unpartitioned Spark tables has the same issue.
--
This is an automated message from the Apache Git Ser
RussellSpitzer commented on code in PR #11317:
URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816909771
##
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##
@@ -78,6 +78,15 @@ private CatalogProperties() {}
public static final boolean IO_MANIF
gaborkaszab commented on code in PR #10995:
URL: https://github.com/apache/iceberg/pull/10995#discussion_r1816970746
##
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##
@@ -252,11 +252,36 @@ public void testFailure() {
assertThat(new File(newManifest.path())).d
lrpt opened a new issue, #11394:
URL: https://github.com/apache/iceberg/issues/11394
Hello everybody,
I have a apache iceberg table in aws glue, this table is partitioned by
string year-month.
When I do a spark.sql("select count(1),partition_field from table group by
partition_field")
nastra commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1816457440
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -74,21 +72,23 @@ public void testToJsonWithOperation() throws IOException {
Immutabl
nastra commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1816458955
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -35,6 +40,58 @@ public class TestSnapshotJson {
public TableOperations ops = new LocalTableO
nastra commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1816457687
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -74,21 +72,23 @@ public void testToJsonWithOperation() throws IOException {
Immutabl
amogh-jahagirdar merged PR #11323:
URL: https://github.com/apache/iceberg/pull/11323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
zeroshade commented on code in PR #179:
URL: https://github.com/apache/iceberg-go/pull/179#discussion_r1816797304
##
cmd/iceberg/main.go:
##
@@ -70,6 +71,7 @@ type Config struct {
Uuid bool `docopt:"uuid"`
Location bool `docopt:"location"`
Propsbo
mrcnc opened a new pull request, #11395:
URL: https://github.com/apache/iceberg/pull/11395
After reviewing the concerns raised in
https://github.com/apache/iceberg/pull/11344 about using `java.net.URI` for
parsing in ADLSLocation, I contrived an example of a location that does not
parse co
RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1816945414
##
core/src/test/java/org/apache/iceberg/TestTables.java:
##
@@ -93,6 +93,26 @@ public static TestTable create(
return new TestTable(ops, name, reporter);
RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1816957914
##
data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java:
##
@@ -0,0 +1,569 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
jbonofre commented on issue #10378:
URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2438057961
@RussellSpitzer sure thing ! I will ! Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
RussellSpitzer commented on code in PR #11317:
URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816909771
##
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##
@@ -78,6 +78,15 @@ private CatalogProperties() {}
public static final boolean IO_MANIF
RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1816930724
##
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##
@@ -249,4 +250,45 @@ public void set(int pos, T value) {
throw new UnsupportedOperat
RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1816936025
##
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##
@@ -249,4 +250,45 @@ public void set(int pos, T value) {
throw new UnsupportedOperat
allilou commented on issue #1087:
URL:
https://github.com/apache/iceberg-python/issues/1087#issuecomment-2438337665
> > I updated my docker-compose.yaml to use extra_hosts and it worked.
Closing this issue.
>
> I'm facing the same error, can you please give a snippet how you add the
RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1817032978
##
core/src/main/java/org/apache/iceberg/data/PartitionStatsRecord.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
stevie9868 commented on PR #1246:
URL: https://github.com/apache/iceberg-python/pull/1246#issuecomment-2438355903
@HonahX
Thanks for unblocking the testing actions!
But looks like the curl command in Python CI/lint-and-test 3.10 times out.
--
This is an automated message from th
jbonofre commented on PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#issuecomment-2439382344
I fixed the issue on `ValueReaders` about strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
pvary commented on code in PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#discussion_r1817698482
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkAvroReaderWriter.java:
##
@@ -91,7 +91,7 @@ private void writeAndValidate(Schema schema, List
stevie9868 commented on PR #1246:
URL: https://github.com/apache/iceberg-python/pull/1246#issuecomment-2439181222
> Ah, do you have `_autocommit` set to `True`? Since both delete and
fast_append ultimately call transaction's `_apply` to queue up the updates,
having `_autocommit` set to `Tru
findepi merged PR #11220:
URL: https://github.com/apache/iceberg/pull/11220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
findepi commented on PR #11220:
URL: https://github.com/apache/iceberg/pull/11220#issuecomment-2439372774
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stevie9868 commented on PR #1246:
URL: https://github.com/apache/iceberg-python/pull/1246#issuecomment-2439178061
> Thanks for the PR @stevie9868. This sounds like an important bug to
address.
>
> Do you know if this bug only applies to the `overwrite` function or all
functions in Tr
singhpk234 commented on code in PR #11396:
URL: https://github.com/apache/iceberg/pull/11396#discussion_r1817628531
##
docs/docs/spark-procedures.md:
##
@@ -402,7 +403,8 @@ Iceberg can compact data files in parallel using Spark with
the `rewriteDataFile
| `rewrite-all` | false
dwilson1988 commented on code in PR #177:
URL: https://github.com/apache/iceberg-go/pull/177#discussion_r1817404112
##
manifest.go:
##
@@ -567,6 +570,97 @@ func ReadManifestList(in io.Reader) ([]ManifestFile,
error) {
return out, dec.Error()
}
+// WriteManifestListV2
danielcweeks merged PR #11379:
URL: https://github.com/apache/iceberg/pull/11379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
jbonofre commented on PR #11380:
URL: https://github.com/apache/iceberg/pull/11380#issuecomment-2434784319
@manuzhang good catch ! I think it makes sense to remove from there. I will
update the PR, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the mes
nastra merged PR #173:
URL: https://github.com/apache/iceberg-go/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
singhpk234 commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1815763222
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java:
##
@@ -84,11 +93,18 @@
import org.apache.kafka.connect.stor
aokolnychyi commented on code in PR #11372:
URL: https://github.com/apache/iceberg/pull/11372#discussion_r1813319794
##
core/src/main/java/org/apache/iceberg/deletes/RoaringPositionBitmap.java:
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815789874
##
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##
@@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long
now, int today) {
singhpk234 commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815498305
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
aihazm commented on issue #10392:
URL: https://github.com/apache/iceberg/issues/10392#issuecomment-2437313152
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
nastra commented on code in PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#discussion_r1816392058
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -138,20 +138,16 @@ protected boolean isCaseSensitive() {
}
protected PartitionSpec
liurenjie1024 merged PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
beyond-up opened a new pull request, #11392:
URL: https://github.com/apache/iceberg/pull/11392
Related to #11391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
pvary commented on PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#issuecomment-2437760336
@huaxingao: I'm not an expert in the Spark codebase, but I think having a
test which fails before the change and succeeds after the change would be nice.
Otherwise we risk future PRs chan
omkenge commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2437567525
Hello @kevinjqliu ,
Could you plz elaborate on this why we need this and what's your thinking ?
From my understanding ,It is integration of Iceberg tables (or views) within
t
RussellSpitzer commented on code in PR #11317:
URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816807747
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##
@@ -365,24 +368,35 @@ public boolean purgeTable(Identifier ident) {
Str
singhpk234 commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815553135
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
amogh-jahagirdar commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815090267
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
amogh-jahagirdar commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1816847378
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
findepi commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2439395678
thank you @tomtongue for your work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
omkenge commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2439396859
Hello Team lets closed this PR ,I will add list_view for hive catalog in new
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
omkenge closed pull request #1249: Add list view for hive catalog
URL: https://github.com/apache/iceberg-python/pull/1249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
omkenge opened a new pull request, #1249:
URL: https://github.com/apache/iceberg-python/pull/1249
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
omkenge closed pull request #1239: feat: Implement list_views Method and
__is_view Utility Function
URL: https://github.com/apache/iceberg-python/pull/1239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
RussellSpitzer commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2438751173
Thanks @ajantha-bhat and @danielcweeks , @rdblue , @manuzhang and
@amogh-jahagirdar for review
--
This is an automated message from the Apache Git Service.
To respond to the me
huaxingao commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1817603690
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java:
##
@@ -81,14 +84,15 @@ private CloseableIterable newParquetIterable(
szehon-ho commented on PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#issuecomment-2438907910
@huaxingao its a good find, im just wondering, where do we add _pos to the
schema? Can we just not do it there? Just curious if its possible
--
This is an automated message from t
amogh-jahagirdar commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438901117
Thanks @kevinjqliu , I caught up on the discussion and this looks right to
me! thanks @nastra , @RussellSpitzer for the reviews.
--
This is an automated message from the Apac
emkornfield commented on code in PR #11238:
URL: https://github.com/apache/iceberg/pull/11238#discussion_r1817239389
##
format/puffin-spec.md:
##
@@ -123,6 +123,54 @@ The blob metadata for this blob may include following
properties:
- `ndv`: estimate of number of distinct va
himadripal commented on code in PR #11396:
URL: https://github.com/apache/iceberg/pull/11396#discussion_r1817404590
##
docs/docs/spark-procedures.md:
##
@@ -402,7 +403,8 @@ Iceberg can compact data files in parallel using Spark with
the `rewriteDataFile
| `rewrite-all` | false
RussellSpitzer merged PR #11346:
URL: https://github.com/apache/iceberg/pull/11346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
kevinjqliu commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438753142
> Yes I meant checking there is no top level "operation" field
{
snapshot {
operation: {} // <-- Did we do this before?
summary: {}
}
@RussellSpitzer I don't thin
aihuaxu commented on PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2438757395
> @aihuaxu, I think there are a couple of things missing:
>
> * The Avro appendix should be updated to state that a Variant is stored as
a Record with two fields, a required binar
emkornfield commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1817237625
##
format/spec.md:
##
@@ -585,13 +589,19 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | _option
RussellSpitzer commented on PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#issuecomment-2438754792
Thanks @singhpk234 for the PR and @jbonofre, @bryanck and @ajantha-bhat For
Review!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
omkenge commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2438763695
Hi @kevinjqliu ,
You are correct that AWS Glue is not support Iceberg View.
It's feasible to implement a list_views function in PyIceberg with the AWS
Glue Catalog, even thoug
danielcweeks commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2438788687
Thanks @mrcnc , though overall it's really unfortunate that we have notably
different behavior between S3 and ADLS in the URI handling. S3 allows for
query params (though they're
RussellSpitzer commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1817325374
##
format/spec.md:
##
@@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following
behavior: `-NaN` < `
A data or delete file is associa
zeroshade commented on code in PR #177:
URL: https://github.com/apache/iceberg-go/pull/177#discussion_r1817390906
##
manifest.go:
##
@@ -567,6 +570,97 @@ func ReadManifestList(in io.Reader) ([]ManifestFile,
error) {
return out, dec.Error()
}
+// WriteManifestListV2 w
aihuaxu commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1817394294
##
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##
@@ -402,6 +406,101 @@ public int hashCode() {
}
}
+ /** A VariantLike implementation for testi
dramaticlly commented on code in PR #11396:
URL: https://github.com/apache/iceberg/pull/11396#discussion_r1817405662
##
docs/docs/spark-procedures.md:
##
@@ -402,7 +403,8 @@ Iceberg can compact data files in parallel using Spark with
the `rewriteDataFile
| `rewrite-all` | fals
huaxingao commented on PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#issuecomment-2438938087
@szehon-ho I think we still need the `_pos` in the `requiredSchema` to build
[`posAccessor`](https://github.com/apache/iceberg/blob/main/data/src/main/java/org/apache/iceberg/data/Dele
huaxingao commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1817436902
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java:
##
@@ -125,4 +129,28 @@ private CloseableIterable newOrcIterable(
.
1 - 100 of 154 matches
Mail list logo
