aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2438757395
> @aihuaxu, I think there are a couple of things missing: > > * The Avro appendix should be updated to state that a Variant is stored as a Record with two fields, a required binary `metadata` and a required binary `value`. Shredding is not supported in Avro. > * The ORC appendix should be updated to state that a Variant is stored as a struct with two fields, a required binary `metadata` and a required binary `value`. Type attribute should be `iceberg.struct-type=variant`. Shredding is not supported in ORC. Thanks @rdblue I thought we will make changes when we start to work on Avro/ORC. I added that. I don't have much context for Json conversion. Not sure if we need to add more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
