RussellSpitzer commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1815720005
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java:
##########
@@ -84,11 +93,18 @@
import org.apache.kafka.connect.storage.ConverterType;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
-public class RecordConverterTest {
+@ExtendWith(ParameterizedTestExtension.class)
+public class RecordConverterTest extends BaseWriterTest {
Review Comment:
Ah iI see, the format only comes into play for UUID so the other
parameterizations are essentially no-ops. Perhaps we just need one specalized
test then ' testParquetUUIDSerialization"
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java:
##########
@@ -84,11 +93,18 @@
import org.apache.kafka.connect.storage.ConverterType;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
-public class RecordConverterTest {
+@ExtendWith(ParameterizedTestExtension.class)
+public class RecordConverterTest extends BaseWriterTest {
Review Comment:
Ah iI see, the format only comes into play for UUID so the other
parameterizations are essentially no-ops. Perhaps we just need one specialized
test then ' testParquetUUIDSerialization"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
