RussellSpitzer commented on code in PR #11317:
URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816807747


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -365,24 +368,35 @@ public boolean purgeTable(Identifier ident) {
       String metadataFileLocation =
           ((HasTableOperations) 
table).operations().current().metadataFileLocation();
 

Review Comment:
   I think it's probably simpler here to just do 
   ```
   // Remote Purge and early exit
   if (catalog.instanceOf[Rest...] and property = true) {
      remote drop purge
      return
   } 
   
   // Original Code Path
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to