nastra commented on PR #10045:
URL: https://github.com/apache/iceberg/pull/10045#issuecomment-2082016600
@snazy could you add a test please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Fokko merged PR #662:
URL: https://github.com/apache/iceberg-python/pull/662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
nastra commented on code in PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#discussion_r1582655185
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -37,23 +43,22 @@
import org.apache.iceberg.relocated.com.google.common.coll
nastra commented on code in PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#discussion_r1582655786
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java:
##
@@ -32,33 +37,37 @@
import org.apache.hadoop.conf.Configuration;
import org
pvary commented on code in PR #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r1582687790
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
ludlows commented on code in PR #10188:
URL: https://github.com/apache/iceberg/pull/10188#discussion_r1582727175
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc
tableDesc, M
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1582743700
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1582745688
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1582748026
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
Fokko merged PR #665:
URL: https://github.com/apache/iceberg-python/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
nk1506 opened a new pull request, #10246:
URL: https://github.com/apache/iceberg/pull/10246
Currently snapshot summary doesn't have statistics related to Manifest
Files.
This change is adding two new summary fields `"total-data-manifest-files"`
and `"total-delete-manifest-files"`. Ther
Fokko commented on code in PR #10007:
URL: https://github.com/apache/iceberg/pull/10007#discussion_r1582803332
##
core/src/main/java/org/apache/iceberg/FastAppend.java:
##
@@ -83,9 +85,13 @@ protected Map summary() {
@Override
public FastAppend appendFile(DataFile file)
Albertagamergod1 commented on issue #10226:
URL: https://github.com/apache/iceberg/issues/10226#issuecomment-2082323233
Continue your work please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nastra merged PR #10124:
URL: https://github.com/apache/iceberg/pull/10124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
liurenjie1024 commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1582960019
##
crates/iceberg/src/arrow/reader.rs:
##
@@ -186,4 +221,637 @@ impl ArrowReader {
Ok(ProjectionMask::leaves(parquet_schema, indices))
}
pvary commented on code in PR #10188:
URL: https://github.com/apache/iceberg/pull/10188#discussion_r1582970748
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc
tableDesc, Map
nastra commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1582996766
##
core/src/main/java/org/apache/iceberg/SnapshotsTable.java:
##
@@ -27,7 +28,8 @@
* This does not include snapshots that have been expired using {@link
ExpireSnapsho
nastra commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1583002079
##
core/src/test/java/org/apache/iceberg/TestDataTaskParser.java:
##
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more con
nastra commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1583003922
##
core/src/test/java/org/apache/iceberg/TestFileScanTaskParser.java:
##
@@ -84,20 +127,38 @@ private String expectedFileScanTaskJson() {
+ "\"residual-filter\"
nastra commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1583006389
##
core/src/test/java/org/apache/iceberg/TestDataTaskParser.java:
##
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more con
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1583019973
##
crates/integrations/datafusion/src/physical_plan/scan.rs:
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
ludlows commented on code in PR #10188:
URL: https://github.com/apache/iceberg/pull/10188#discussion_r1583036309
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc
tableDesc, M
liurenjie1024 commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1583008556
##
crates/iceberg/src/arrow/reader.rs:
##
@@ -186,4 +219,634 @@ impl ArrowReader {
Ok(ProjectionMask::leaves(parquet_schema, indices))
}
javrasya opened a new issue, #10247:
URL: https://github.com/apache/iceberg/issues/10247
### Apache Iceberg version
1.4.3
### Query engine
Spark
### Please describe the bug 🐞
We had to rollback our table because it had some broken snapshots. We are
turning
marvinlanhenke opened a new pull request, #360:
URL: https://github.com/apache/iceberg-rust/pull/360
### Which issue does this PR close?
Closes #359
### Rationale for this change
The `partition_filter` (inclusive projection) is not only required by the
`ManifestEvaluator` but al
marvinlanhenke commented on PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#issuecomment-2082804625
@sdd @Fokko @liurenjie1024 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Gowthami03B commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583225201
##
tests/integration/test_inspect_table.py:
##
@@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table,
spark_df: DataFrame) -> Non
Gowthami03B commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583228304
##
tests/conftest.py:
##
@@ -2060,7 +2060,7 @@ def spark() -> "SparkSession":
.config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")
Gowthami03B commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1573767911
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,58 @@ def update_partitions_map(
schema=table_schema,
)
+def files(self) -> "pa
syun64 opened a new pull request, #668:
URL: https://github.com/apache/iceberg-python/pull/668
PyArrow HadoopFileSystem is a thin wrapper around
[libhdfs](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/LibHdfs.html).
For a given hdfs uri string that looks like `
RussellSpitzer commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1583299839
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeabl
syun64 commented on issue #449:
URL: https://github.com/apache/iceberg-python/issues/449#issuecomment-2083068661
Hi @luocan17 thank you for raising this issue. I have a PR up to attempt a
fix. Could I ask for your review on:
https://github.com/apache/iceberg-python/pull/668
--
This is an
stevenzwu commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1583309420
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
tomtongue commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2083084976
Thanks for the review. Sure, will add the changes for
`TestFlinkSourceConfig` and removing the testbase.
--
This is an automated message from the Apache Git Service.
To respond to t
EXPEbdodla commented on issue #10234:
URL: https://github.com/apache/iceberg/issues/10234#issuecomment-2083137068
> Which Spark version are you using?
I was originally trying with Spark 3.3.0 and iceberg 1.2.1 version.
Later I tried with Spark-iceberg docker images
`tabulario/
huaxingao commented on PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#issuecomment-2083223651
@aokolnychyi I have addressed the comments. Could you please take one more
look when you have a moment? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To r
marvinlanhenke commented on code in PR #347:
URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1583517231
##
crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs:
##
@@ -0,0 +1,744 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
sdd commented on code in PR #347:
URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1583560775
##
crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs:
##
@@ -0,0 +1,744 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
sdd commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583574672
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning operations
+///
sdd commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583579994
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning operations
+///
sdd commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583577520
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning operations
+///
javrasya commented on issue #10247:
URL: https://github.com/apache/iceberg/issues/10247#issuecomment-2083426721
Exactly @manuzhang . It feels like it should filter that out and this is a
bug. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583607459
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583606448
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
Fokko commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1583486316
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -16,74 +16,49 @@
// under the License.
use crate::expr::visitors::bound_predicate_visitor::{visit,
yakovsushenok opened a new issue, #10249:
URL: https://github.com/apache/iceberg/issues/10249
### Apache Iceberg version
None
### Query engine
None
### Please describe the bug 🐞
[This](https://iceberg.apache.org/docs/1.5.0/spark-configuration.md#sql-extensi
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1583629653
##
crates/iceberg/src/arrow/reader.rs:
##
@@ -186,4 +221,637 @@ impl ArrowReader {
Ok(ProjectionMask::leaves(parquet_schema, indices))
}
}
marvinlanhenke commented on PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#issuecomment-2083513030
@Fokko thanks for clearing this up and thanks for the review. This was is
the
[line](https://github.com/apache/iceberg-python/blob/main/pyiceberg%2Ftable%2F__init__.py#L1647)
t
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1583669332
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1583671212
##
docs/docs/flink-configuration.md:
##
@@ -124,8 +124,9 @@ env.getConfig()
| max-planning-snapshot-count |
connector.iceberg.max-planning-snapshot-count |
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583779367
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583779367
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583798006
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entries(
dimas-b commented on PR #10248:
URL: https://github.com/apache/iceberg/pull/10248#issuecomment-2083757084
@nastra : WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mrbrahman opened a new issue, #10250:
URL: https://github.com/apache/iceberg/issues/10250
### Query engine
Spark on AWS EMR 6.15
### Question
Trying to get Storage Partitioned join to work in a simple test case, but
not successful. I followed most of the settings mentio
geruh commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583803213
##
tests/integration/test_inspect_table.py:
##
@@ -445,3 +445,107 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table,
spark_df: DataFrame) -> Non
df =
vtk9 opened a new issue, #669:
URL: https://github.com/apache/iceberg-python/issues/669
### Apache Iceberg version
0.6.0 (latest release)
### Please describe the bug 🐞
Hello,
Is this a bug or is there something obvious I am misunderstanding/misusing.
(I am relativ
dependabot[bot] opened a new pull request, #670:
URL: https://github.com/apache/iceberg-python/pull/670
Bumps [mkdocs](https://github.com/mkdocs/mkdocs) from 1.5.3 to 1.6.0.
Release notes
Sourced from https://github.com/mkdocs/mkdocs/releases";>mkdocs's releases.
1.6.0
Loc
dependabot[bot] opened a new pull request, #671:
URL: https://github.com/apache/iceberg-python/pull/671
Bumps [mkdocs-autorefs](https://github.com/mkdocstrings/autorefs) from 0.5.0
to 1.0.1.
Release notes
Sourced from https://github.com/mkdocstrings/autorefs/releases";>mkdocs-autor
dependabot[bot] opened a new pull request, #672:
URL: https://github.com/apache/iceberg-python/pull/672
Bumps [ray](https://github.com/ray-project/ray) from 2.9.2 to 2.12.0.
Release notes
Sourced from https://github.com/ray-project/ray/releases";>ray's releases.
Ray-2.12.0
dependabot[bot] opened a new pull request, #673:
URL: https://github.com/apache/iceberg-python/pull/673
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.19 to 9.5.20.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk
github-actions[bot] commented on issue #2498:
URL: https://github.com/apache/iceberg/issues/2498#issuecomment-2083906772
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2504: Flink CDC | OOM during initial snapshot
URL: https://github.com/apache/iceberg/issues/2504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
github-actions[bot] commented on issue #2507:
URL: https://github.com/apache/iceberg/issues/2507#issuecomment-2083906823
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2513: Partitioning on sensitive (encrypted)
columns
URL: https://github.com/apache/iceberg/issues/2513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] closed issue #2498: Iceberg supports Tencent COS
URL: https://github.com/apache/iceberg/issues/2498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on issue #2517:
URL: https://github.com/apache/iceberg/issues/2517#issuecomment-2083906854
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2517: Predicate pushdown not visible in Spark
plan
URL: https://github.com/apache/iceberg/issues/2517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on issue #2525:
URL: https://github.com/apache/iceberg/issues/2525#issuecomment-2083906870
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2525: The spark's remove_orphan_files
procedure cannot expire the orphan files that located in remote object storage
services
URL: https://github.com/apache/iceberg/issues/2525
--
This is an automated message from the Apache Git Service.
To respond to the me
jqin61 commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-2083999610
Updates for monthly sync:
1. Working on dynamic overwrite which gets unblocked by partial deletes
https://github.com/apache/iceberg-python/pull/569
2. For transforms functio
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584036888
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entrie
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584037066
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entrie
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584040866
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(re
amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1584047406
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1584048101
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
djouallah commented on issue #507:
URL: https://github.com/apache/iceberg-python/issues/507#issuecomment-2084257385
@kevinjqliu is this supported ?
`AttributeError: 'SqlCatalog' object has no attribute 'table_exists'`
--
This is an automated message from the Apache Git Service.
To
manuzhang commented on issue #10249:
URL: https://github.com/apache/iceberg/issues/10249#issuecomment-2084280354
We are still fixing doc links in previous releases tracked at #10116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mrbrahman commented on issue #10250:
URL: https://github.com/apache/iceberg/issues/10250#issuecomment-2084281224
The problem was the commented out parameter. Apparently I had to set it thus:
~~~sql
set `spark.sql.iceberg.planning.preserve-data-grouping` = true;
~~~
Once th
djouallah commented on issue #674:
URL: https://github.com/apache/iceberg-python/issues/674#issuecomment-2084298893
sorry, may fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
shivjha30 commented on code in PR #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r1584078574
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584098222
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584100390
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584100390
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584100390
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584100390
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584111575
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -16,74 +16,49 @@
// under the License.
use crate::expr::visitors::bound_predicate_visitor
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584112041
##
crates/iceberg/src/scan.rs:
##
@@ -99,7 +107,7 @@ impl<'a> TableScanBuilder<'a> {
}
/// Build the table scan.
-pub fn build(self) -> crate:
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584120346
##
crates/iceberg/src/scan.rs:
##
@@ -169,55 +177,66 @@ pub struct TableScan {
filter: Option>,
}
-/// A stream of [`FileScanTask`].
-pub type FileSca
marvinlanhenke commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1584100390
##
crates/iceberg/src/scan.rs:
##
@@ -314,6 +312,140 @@ impl TableScan {
}
}
+#[derive(Debug)]
+/// Holds the context necessary for file scanning oper
nk1506 commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584136686
##
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##
@@ -190,6 +190,7 @@ public List apply(TableMetadata base,
Snapshot snapshot) {
List apply
nk1506 commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584137262
##
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##
@@ -263,6 +273,12 @@ void addTo(ImmutableMap.Builder builder) {
setIf(removedDeleteFiles > 0,
pvary commented on code in PR #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r1584145169
##
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
igoradulian commented on PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2084436773
@nastra, please review recent changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
nastra commented on PR #10248:
URL: https://github.com/apache/iceberg/pull/10248#issuecomment-2084445178
@YuzongG just curious, where are you planning to re-use this as this should
only be used internally in `NessieTableOperations` / `NessieViewOperations`
--
This is an automated message
bigluck commented on issue #669:
URL: https://github.com/apache/iceberg-python/issues/669#issuecomment-2084469240
For reference, this is the full stack trace:
```
Traceback (most recent call last):
File "/Users/bigluck/Desktop/pyiceberg-vlad-bug/test.py", line 31, in
n
liurenjie1024 commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1584204040
##
crates/iceberg/src/arrow/reader.rs:
##
@@ -186,4 +221,637 @@ impl ArrowReader {
Ok(ProjectionMask::leaves(parquet_schema, indices))
}
bigluck commented on issue #669:
URL: https://github.com/apache/iceberg-python/issues/669#issuecomment-2084497090
@Fokko `decimal_to_bytes`, when invoked without `byte_length`, uses
`bytes_required` to get the required number of bytes.
```python
for v in ['32767', '32768', '32769',
Xuanwo commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1584213613
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
liurenjie1024 commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1584229759
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
100 matches
Mail list logo