Fokko commented on code in PR #10007:
URL: https://github.com/apache/iceberg/pull/10007#discussion_r1582803332
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -83,9 +85,13 @@ protected Map<String, String> summary() {
@Override
public FastAppend appendFile(DataFile file) {
- this.hasNewFiles = true;
- newFiles.add(file);
- summaryBuilder.addedFile(spec, file);
+ Preconditions.checkNotNull(file, "Invalid data file: null");
+ if (newFilePaths.add(file.path())) {
+ this.hasNewFiles = true;
Review Comment:
Nit: This flag could also be replaced by `newFilePaths.length() > 0`. We
could also do this in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
