ludlows commented on code in PR #10188:
URL: https://github.com/apache/iceberg/pull/10188#discussion_r1582727175
##########
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc
tableDesc, Map<String, String>
// @Override
public void configureInputJobCredentials(TableDesc tableDesc, Map<String,
String> secrets) {}
+ private void setCommonJobConf(JobConf jobConf) {
Review Comment:
Hi @pvary , thanks for your suggestions.
now I have implemented one unit test.
however, according to the test result, it seems that my modification doesn't
take effects.
could you give me a hint about the test failure ?
many thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
