corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583798006
##########
pyiceberg/table/__init__.py:
##########
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+ def metadata_log_entries(self) -> "pa.Table":
+ import pyarrow as pa
+
+ from pyiceberg.table.snapshots import MetadataLogEntry
+
+ table_schema = pa.schema([
+ ("timestamp", pa.timestamp(unit='ms'), True),
+ ("file", pa.string(), True),
Review Comment:
why are file and timestamp nullable? In what scenarios is it expected to
have a log entry with a snapshot id but no timestamp or file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
