pvary commented on code in PR #10188: URL: https://github.com/apache/iceberg/pull/10188#discussion_r1582970748
########## mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ########## @@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc tableDesc, Map<String, String> // @Override public void configureInputJobCredentials(TableDesc tableDesc, Map<String, String> secrets) {} + private void setCommonJobConf(JobConf jobConf) { Review Comment: I think the changes effect of the configuration used by the query, and do not effect the configuration used by the shell. You could check the values on the executors when the job is running. Or you could check the result of the query. Create a test which fails without the change because of the wrong pruning, and successful after the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org