kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584036888
##########
pyiceberg/table/__init__.py:
##########
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+ def metadata_log_entries(self) -> "pa.Table":
+ import pyarrow as pa
+
+ from pyiceberg.table.snapshots import MetadataLogEntry
+
+ table_schema = pa.schema([
+ ("timestamp", pa.timestamp(unit='ms'), True),
+ ("file", pa.string(), True),
Review Comment:
ah, good catch. `timestamp` and `file` should both be required fields,
according to the [Java
schema](https://github.com/apache/iceberg/blob/1e35bf96ecacd5c5175116f40fa3e097991d04d2/core/src/main/java/org/apache/iceberg/MetadataLogEntriesTable.java#L30-L35).
The third element of the tuple represents
[`nullable`](https://arrow.apache.org/docs/python/generated/pyarrow.schema.html),
which should be `False` for both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
