ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580571634
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match sch
lurnagao-dahua commented on PR #10210:
URL: https://github.com/apache/iceberg/pull/10210#issuecomment-2078820125
@Fokko I am very much looking forward to and grateful for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
pvary merged PR #10208:
URL: https://github.com/apache/iceberg/pull/10208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#issuecomment-2079121401
Merged to master.
Thanks for the review @stevenzwu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
pvary commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1580858492
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -140,12 +159,18 @@ public void write(T row) throws IOException {
PathOffset previous = ins
pvary commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1580859044
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1580860665
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn = watermarkCo
Fokko merged PR #659:
URL: https://github.com/apache/iceberg-python/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #8625:
URL: https://github.com/apache/iceberg/pull/8625#issuecomment-2079228113
Here we go: https://github.com/apache/avro/pull/2874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1580967711
##
crates/integrations/datafusion/src/catalog.rs:
##
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580983794
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List listTab
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580985211
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List listNamespaces
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580991187
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertTh
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580993539
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertTh
nastra merged PR #10223:
URL: https://github.com/apache/iceberg/pull/10223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1581067924
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
pvary commented on issue #10219:
URL: https://github.com/apache/iceberg/issues/10219#issuecomment-2079437298
What would be needed to support them?
I am guessing that this would be a Flink specific conversion between the
Iceberg table and the Flink table. Am I right here?
--
This is an
pvary merged PR #10230:
URL: https://github.com/apache/iceberg/pull/10230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #10230:
URL: https://github.com/apache/iceberg/pull/10230#issuecomment-2079441307
Merged to main.
Thanks for the review @Fokko and @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
amogh-jahagirdar commented on code in PR #10229:
URL: https://github.com/apache/iceberg/pull/10229#discussion_r1581079152
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##
@@ -398,12 +399,14 @@ static List findOrphanFiles(
amogh-jahagirdar commented on code in PR #10229:
URL: https://github.com/apache/iceberg/pull/10229#discussion_r1581081749
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##
@@ -398,12 +399,14 @@ static List findOrphanFiles(
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581114289
##
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##
@@ -56,26 +69,38 @@ public R run(Action action, boolean retry)
throws E, InterruptedExc
C clien
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581117582
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -21,17 +21,27 @@
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581117582
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -21,17 +21,27 @@
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581120323
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map
props) {
}
public JdbcClientP
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581120323
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map
props) {
}
public JdbcClientP
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581123625
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -40,6 +40,8 @@ final class JdbcUtil {
// property to control if view support is added to the exis
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581124122
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map
props) {
}
public JdbcClientP
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581125222
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581127109
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581127958
##
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581129079
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -167,6 +168,67 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catal
kevinjqliu commented on issue #654:
URL: https://github.com/apache/iceberg-python/issues/654#issuecomment-2079530539
I see, so the issue here is that the `__init__` function sets the
`self._filesystem` variable
https://github.com/apache/iceberg-python/blob/a74c45dc08ec809e59ac1cbc908a340
kevinjqliu commented on issue #654:
URL: https://github.com/apache/iceberg-python/issues/654#issuecomment-2079537070
I think its safe to rename the class variable from `_fs` to `_filesystem`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581204955
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertT
simonvandel commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1581219550
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
simonvandel commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1581219550
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
amogh-jahagirdar commented on code in PR #10229:
URL: https://github.com/apache/iceberg/pull/10229#discussion_r1581262173
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##
@@ -398,13 +399,13 @@ static List findOrphanFiles(
pvary merged PR #10207:
URL: https://github.com/apache/iceberg/pull/10207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1581362714
##
crates/integrations/datafusion/src/table.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581388814
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List listTa
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581389185
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List listNamespace
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581390737
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertT
danielcweeks commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1581455195
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2106,6 +2210,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
JanKaul commented on code in PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1581470280
##
crates/catalog/sql/src/catalog.rs:
##
@@ -0,0 +1,517 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
EXPEbdodla opened a new issue, #10234:
URL: https://github.com/apache/iceberg/issues/10234
### Apache Iceberg version
1.5.1 (latest release)
### Query engine
Spark
### Please describe the bug 🐞
Problem: Dropping an old partition spec column corrupts table. M
amogh-jahagirdar commented on code in PR #10229:
URL: https://github.com/apache/iceberg/pull/10229#discussion_r1581496884
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##
@@ -398,13 +399,13 @@ static List findOrphanFiles(
Gowthami03B commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1581522746
##
tests/conftest.py:
##
@@ -2060,7 +2060,7 @@ def spark() -> "SparkSession":
.config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")
kevinjqliu commented on code in PR #614:
URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1581548947
##
tests/conftest.py:
##
@@ -2060,7 +2060,7 @@ def spark() -> "SparkSession":
.config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")
kevinjqliu commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1581278513
##
pyiceberg/table/__init__.py:
##
@@ -434,6 +456,9 @@ def overwrite(
if table_arrow_schema != df.schema:
df = df.cast(table_arrow_schema)
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581389185
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List listNamespace
dependabot[bot] opened a new pull request, #663:
URL: https://github.com/apache/iceberg-python/pull/663
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.18 to 9.5.19.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581590662
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List listTa
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581591136
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertT
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581598929
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List listNamespace
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581590662
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List listTa
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2080224394
Thanks @nastra for the help I appreciate it, will wait on @danielcweeks
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #2486:
URL: https://github.com/apache/iceberg/issues/2486#issuecomment-2080252964
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2486: Add support and test cases in
ArrowReader for UUIDType, FixedType and DecimalType data types
URL: https://github.com/apache/iceberg/issues/2486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
github-actions[bot] closed issue #2487: Add support for Iceberg v2 spec in the
ArrowReader
URL: https://github.com/apache/iceberg/issues/2487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] commented on issue #2487:
URL: https://github.com/apache/iceberg/issues/2487#issuecomment-2080252981
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2490: Table SortOrder not being respected in
Spark write
URL: https://github.com/apache/iceberg/issues/2490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] commented on issue #2490:
URL: https://github.com/apache/iceberg/issues/2490#issuecomment-2080252994
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #2718:
URL: https://github.com/apache/iceberg/issues/2718#issuecomment-2080253087
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1581637078
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1581637078
##
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##
@@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter
implements Closeable {
dennishuo commented on issue #10127:
URL: https://github.com/apache/iceberg/issues/10127#issuecomment-2080302481
@ms raises a good point, as there are some known incompatibilities in
low-level Blob vs ADLS APIs:
https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-kno
dennishuo commented on issue #10127:
URL: https://github.com/apache/iceberg/issues/10127#issuecomment-2080319607
A cursory check through
https://github.com/apache/iceberg/blob/main/azure/src/main/java/org/apache/iceberg/azure/adlsv2
seems to only reveal three methods used:
- `fileCli
68 matches
Mail list logo