amogh-jahagirdar commented on code in PR #10229:
URL: https://github.com/apache/iceberg/pull/10229#discussion_r1581262173
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -398,13 +399,13 @@ static List<String> findOrphanFiles(
spark.sparkContext().register(conflicts);
Column joinCond =
actualFileIdentDS.col("path").equalTo(validFileIdentDS.col("path"));
-
- List<String> orphanFiles =
+ PatriciaTrie<String> files = new PatriciaTrie<>();
Review Comment:
We don't really leverage the efficient search provided by tries for orphan
files; rather I'm looking into the memory saving aspects of this structure when
prefixes are repeated many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
