nastra commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581129079
########## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ########## @@ -167,6 +168,67 @@ public void testInitialize() { jdbcCatalog.initialize("test_jdbc_catalog", properties); } + @Test + public void testRetryingErrorCodesProperty() { + Map<String, String> properties = Maps.newHashMap(); + properties.put(CatalogProperties.WAREHOUSE_LOCATION, this.tableDir.toAbsolutePath().toString()); + properties.put(CatalogProperties.URI, "jdbc:sqlite:file::memory:?icebergDB"); + properties.put(JdbcUtil.RETRYABLE_STATUS_CODES, "57000,57P03,57P04"); Review Comment: we might want to double-check here in case users pass this with a space after the comma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org