nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580993539
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
assertThat(schema2.columns()).hasSize(1);
}
+ @Test
+ public void testInvalidRestPageSize() {
+ RESTCatalogAdapter adapter = Mockito.spy(new
RESTCatalogAdapter(backendCatalog));
+ RESTCatalog catalog =
+ new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
+ Assertions.assertThatThrownBy(
+ () ->
+ catalog.initialize(
+ "test", ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE,
"-1")))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Invalid value for pageSize, must be a positive integer");
+ }
+
+ @Test
+ public void testPaginationForListNamespaces() {
+ RESTCatalogAdapter adapter = Mockito.spy(new
RESTCatalogAdapter(backendCatalog));
+ RESTCatalog catalog =
+ new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
+ catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
+ int numberOfItems = 20;
Review Comment:
I would probably increase this to 30 and then add one additional check below
with pageToken=20 / pageSize=10 just so that we don't hide any potential bugs.
Same for the other pagination tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
