dennishuo commented on issue #10127: URL: https://github.com/apache/iceberg/issues/10127#issuecomment-2080319607
A cursory check through https://github.com/apache/iceberg/blob/main/azure/src/main/java/org/apache/iceberg/azure/adlsv2 seems to only reveal three methods used: - `fileClient.getProperties`: https://github.com/Azure/azure-sdk-for-java/blob/0aa45226a625aa19da7183800bb90531eb1f1ee2/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java#L1206 - `fileClient.openInputStream`: https://github.com/Azure/azure-sdk-for-java/blob/0aa45226a625aa19da7183800bb90531eb1f1ee2/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileClient.java#L1139 - `fileClient.getOutputStream`: https://github.com/Azure/azure-sdk-for-java/blob/0aa45226a625aa19da7183800bb90531eb1f1ee2/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileClient.java#L1189 And all three appear to just delegate through to the internal `blockBlobClient` instead of touching `dataLakeFileAsyncClient`, so it does seem like simply accepting `wasbs` in `ADLSFileIO` should be sufficient. Would be good to have a second set of eyes confirm though. It could also be safest to just make `ADLSLocation` permissive in accepting `wasbs://` without changing `ResolvingFileIO` if people want `wasbs://` to still automatically fallthrough to HadoopFileIO in usual scenarios. @njriasan I'm happy to help review a PR if you wanted to take a stab at this (we'll naturally still need a committer to also review). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
