nastra commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581124122
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##########
@@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map<String, String>
props) {
}
public JdbcClientPool(int poolSize, String dbUrl, Map<String, String> props)
{
- super(poolSize, SQLNonTransientConnectionException.class, true);
+ super(poolSize, SQLTransientException.class, true);
properties = props;
+ retryableStatusCodes = Sets.newHashSet();
+ retryableStatusCodes.addAll(COMMON_RETRYABLE_CONNECTION_SQL_STATES);
+ String configuredRetryableStatuses =
props.get(JdbcUtil.RETRYABLE_STATUS_CODES);
+ if (configuredRetryableStatuses != null) {
+ retryableStatusCodes.addAll(
+
Arrays.stream(configuredRetryableStatuses.split(",")).collect(Collectors.toSet()));
Review Comment:
we might need to make sure that users don't accidentally pass this with
spaces: `123, 456, 789`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
