Re: [PR] Spark: Detect temp functions in views [iceberg]

nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1502175277 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1502175828 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,20 @@ case class RewriteViewCommands(s

[I] Writing Equality Deletes using Iceberg Java API [iceberg]

robinsinghstudios opened a new issue, #9808: URL: https://github.com/apache/iceberg/issues/9808 ### Query engine Java API ### Question I am trying to implement an Iceberg writer based completely on Java API. I am able to use the PartitionedFanoutWriter to write to the sp

Re: [PR] Spark: Include catalog name in view errors [iceberg]

Fokko commented on code in PR #9807: URL: https://github.com/apache/iceberg/pull/9807#discussion_r1502194414 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -33,9 +32,9 @@ object CheckViews extends (LogicalPlan => Unit

Re: [PR] Spark: Include catalog name in view errors [iceberg]

nastra commented on code in PR #9807: URL: https://github.com/apache/iceberg/pull/9807#discussion_r1502199832 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -33,9 +32,9 @@ object CheckViews extends (LogicalPlan => Uni

[I] ci: Security audit failed. [iceberg-rust]

liurenjie1024 opened a new issue, #221: URL: https://github.com/apache/iceberg-rust/issues/221 See [workflow](https://github.com/apache/iceberg-rust/actions/runs/8018117597/job/21903364175). We may need to wait for rsa to upgrade to fix it. -- This is an automated message from the Apache

Re: [I] ci: Security audit failed. [iceberg-rust]

liurenjie1024 commented on issue #221: URL: https://github.com/apache/iceberg-rust/issues/221#issuecomment-1963562178 cc @Xuanwo Other opendal user confront this error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] ci: Security audit failed. [iceberg-rust]

Xuanwo commented on issue #221: URL: https://github.com/apache/iceberg-rust/issues/221#issuecomment-1963590945 > cc @Xuanwo Other opendal user confront this error? I'm guessing most of them just ignore it since nothing we can do about it. -- This is an automated message from the Apa

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

nastra commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1502235397 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,35 @@ public void showViews() throws NoSuchTableExce

Re: [I] ci: Security audit failed due to rsa. [iceberg-rust]

liurenjie1024 commented on issue #221: URL: https://github.com/apache/iceberg-rust/issues/221#issuecomment-1963603323 Let's leave this open until rsa crate has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

nastra commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1502235397 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,35 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spark 3.4: Fail if temp functions are used in views [iceberg]

nastra merged PR #9809: URL: https://github.com/apache/iceberg/pull/9809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] ci: Security audit failed due to rsa. [iceberg-rust]

Xuanwo commented on issue #221: URL: https://github.com/apache/iceberg-rust/issues/221#issuecomment-1963623330 Let me create a PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1502261145 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Arg

Re: [PR] [AWS][Docs] S3FileIO - Add Cross-Region Bucket Access. [iceberg]

elmehdibelgasmi commented on PR #9805: URL: https://github.com/apache/iceberg/pull/9805#issuecomment-1963636360 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Flink: Supports specifying comment for iceberg fields in create table and addcolumn syntax using flinksql [iceberg]

pvary commented on code in PR #9606: URL: https://github.com/apache/iceberg/pull/9606#discussion_r1502277710 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java: ## @@ -68,6 +73,42 @@ public static Schema convert(TableSchema schema) { return fre

Re: [I] Schema Evolution exception: too many data columns [iceberg]

mixermt commented on issue #4542: URL: https://github.com/apache/iceberg/issues/4542#issuecomment-1963666833 @RussellSpitzer > We already have merge schema support > > https://github.com/apache/iceberg/blob/1f1ec4be478feae79b04bcea3e9a8556d8076054/spark/v3.2/spark/src/main/java/or

Re: [PR] Spark: Include catalog name in view errors [iceberg]

nastra merged PR #9807: URL: https://github.com/apache/iceberg/pull/9807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Parallel Table.append [iceberg-python]

bigluck commented on issue #428: URL: https://github.com/apache/iceberg-python/issues/428#issuecomment-1963740242 @kevinjqliu, your latest changes are mind-blowing (https://github.com/apache/iceberg-python/issues/428#issuecomment-1962460623 for reference) I have tested your last cha

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

tomtongue commented on PR #9790: URL: https://github.com/apache/iceberg/pull/9790#issuecomment-1963776496 @nastra This is the last PR for the migration to spark-extensions except for [SmokeTest in spark-runtime](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-runtime/src/integr

[PR] Spark 3.4: Include catalog name in view errors [iceberg]

nastra opened a new pull request, #9810: URL: https://github.com/apache/iceberg/pull/9810 This backports #9807 to Spark 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Spark 3.4: Include catalog name in view errors [iceberg]

nastra commented on code in PR #9810: URL: https://github.com/apache/iceberg/pull/9810#discussion_r1502407117 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -123,12 +123,9 @@ case class RewriteViewCommands(sp

Re: [PR] Spark 3.4: Include catalog name in view errors [iceberg]

nastra commented on code in PR #9810: URL: https://github.com/apache/iceberg/pull/9810#discussion_r1502407635 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -35,10 +35,7 @@ import org.apache.spark.sql.cataly

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

nastra commented on code in PR #9790: URL: https://github.com/apache/iceberg/pull/9790#discussion_r1502413467 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -51,30 +52,31 @@ import org.apache.spark.sql.catalyst.analysis.No

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

nastra commented on code in PR #9790: URL: https://github.com/apache/iceberg/pull/9790#discussion_r1502417922 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownDQL.java: ## @@ -72,23 +70,23 @@ public static Object[][] para

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

nastra commented on code in PR #9790: URL: https://github.com/apache/iceberg/pull/9790#discussion_r1502421258 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -204,46 +198,44 @@ public void testPartitionedTable() thr

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

nastra commented on code in PR #9790: URL: https://github.com/apache/iceberg/pull/9790#discussion_r1502425979 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -605,43 +597,64 @@ public void testSnapshotReferencesMeta

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

nastra commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1963871923 @bitsondatadev I've verified the changes locally when reviewing and things look good and work as expected -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Build: Ignore major version update in dependabot [iceberg]

nastra merged PR #9806: URL: https://github.com/apache/iceberg/pull/9806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.41.0 [iceberg]

nastra closed pull request #9799: Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.41.0 URL: https://github.com/apache/iceberg/pull/9799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.41.0 [iceberg]

dependabot[bot] commented on PR #9799: URL: https://github.com/apache/iceberg/pull/9799#issuecomment-1963874968 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump com.adobe.testing:s3mock-junit5 from 2.11.0 to 3.5.1 [iceberg]

nastra closed pull request #9798: Build: Bump com.adobe.testing:s3mock-junit5 from 2.11.0 to 3.5.1 URL: https://github.com/apache/iceberg/pull/9798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Build: Bump com.adobe.testing:s3mock-junit5 from 2.11.0 to 3.5.1 [iceberg]

dependabot[bot] commented on PR #9798: URL: https://github.com/apache/iceberg/pull/9798#issuecomment-1963875075 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Migrate Read and other sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

tomtongue commented on PR #9790: URL: https://github.com/apache/iceberg/pull/9790#issuecomment-1963880211 Thanks for the review. Sure, will include the SmokeTest with updates based on your reviews. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Flink 1.18: Fix iceberg source plan parallelism not effective. [iceberg]

Reo-LEI commented on PR #9761: URL: https://github.com/apache/iceberg/pull/9761#issuecomment-1963880228 @pvary Thanks for reminding! The ported PR is [here](https://github.com/apache/iceberg/pull/9811). -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Flink 1.18: Fix continuous enumerator lost enumeration history state when restore from checkpoint. [iceberg]

Reo-LEI commented on PR #9762: URL: https://github.com/apache/iceberg/pull/9762#issuecomment-1963880959 @mas-chen Thanks for reminding! The ported PR is [here](https://github.com/apache/iceberg/pull/9812). -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502436883 ## data/src/test/java/org/apache/iceberg/TestMergingMetrics.java: ## @@ -30,13 +30,14 @@ import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.ato

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502439184 ## data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java: ## @@ -43,7 +42,7 @@ public static void assertEquals(Types.StructType struct, Record expected, Recor

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502439647 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -45,11 +46,13 @@ import org.apache.iceberg.util.Pair; import org.apache.iceberg.util.StructLi

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502440260 ## data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java: ## @@ -70,7 +73,10 @@ public abstract class DeleteReadTests { public static final PartitionSpec DA

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502443431 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -31,7 +32,8 @@ import org.apache.iceberg.types.Types.MapType; import org.apache.iceberg.types.Types.

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

nastra commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1502445553 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -315,13 +315,13 @@ public void close() throws IOException { @Override public List l

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

nastra commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1502446024 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -138,13 +138,13 @@ public boolean dropTable(TableIdentifier tableIdentifier, boolean purge

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

Fokko commented on code in PR #9776: URL: https://github.com/apache/iceberg/pull/9776#discussion_r1501571410 ## site/docs/contribute.md: ## @@ -145,6 +148,84 @@ Example: void sequenceNumber(long sequenceNumber); ``` +## Adding new functionality without breaking APIs +Ideal

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

nastra commented on PR #9776: URL: https://github.com/apache/iceberg/pull/9776#issuecomment-1963941126 thanks for reviewing @Fokko, I've applied your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

nastra merged PR #9776: URL: https://github.com/apache/iceberg/pull/9776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Writing Equality Deletes using Iceberg Java API [iceberg]

ismailsimsek commented on issue #9808: URL: https://github.com/apache/iceberg/issues/9808#issuecomment-1963949626 @robinsinghstudios i have done [similar implementation here ](https://github.com/memiiso/debezium-server-iceberg/tree/master/debezium-server-iceberg-sink/src/main/java/io/debeziu

Re: [PR] Flink: Supports specifying comment for iceberg fields in create table and addcolumn syntax using flinksql [iceberg]

huyuanfeng2018 commented on code in PR #9606: URL: https://github.com/apache/iceberg/pull/9606#discussion_r1502526761 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java: ## @@ -68,6 +73,42 @@ public static Schema convert(TableSchema schema) { r

Re: [PR] Build: Free disk space before running action in Spark CI [iceberg]

ajantha-bhat commented on PR #9786: URL: https://github.com/apache/iceberg/pull/9786#issuecomment-1964061257 @manuzhang: Very nice to see this addition. Have we benchmarked how long it took to clean it up and overall increase in CI time with this? -- This is an automated message from the

Re: [PR] Flink: backport #9762 to Flink 1.16 and 1.17 for fix continuous enumerator lost enumeration history state when restore from checkpoint. [iceberg]

nastra merged PR #9812: URL: https://github.com/apache/iceberg/pull/9812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Flink: backport #9761 to Flink 1.16 and 1.17 for fix iceberg source plan parallelism not effective. [iceberg]

nastra merged PR #9811: URL: https://github.com/apache/iceberg/pull/9811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Make CatalogHandlers.commit public [iceberg]

N-o-Z commented on PR #9789: URL: https://github.com/apache/iceberg/pull/9789#issuecomment-1964153139 > I believe the purpose was that `CatalogHandlers.commit(..)` should only be used through `CatalogHandlers.updateTable(...)`. Is there a particular issue that prevents you from going throug

Re: [PR] Build: Free disk space before running action in Spark CI [iceberg]

manuzhang commented on PR #9786: URL: https://github.com/apache/iceberg/pull/9786#issuecomment-1964179087 @ajantha-bhat It took around two minutes per action run. I suppose actions are run in parallel so that's also the overall increase time? ![CleanShot 2024-02-26 at 21 40 35@2x](https:

[PR] enable set hadoop ugi for hive catalog. [iceberg-python]

j7nhai opened a new pull request, #472: URL: https://github.com/apache/iceberg-python/pull/472 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502705557 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] enable set hadoop ugi for hive catalog [iceberg-python]

Fokko commented on code in PR #472: URL: https://github.com/apache/iceberg-python/pull/472#discussion_r1502712949 ## pyiceberg/catalog/hive.py: ## @@ -130,17 +130,22 @@ class _HiveClient: _transport: TTransport _client: Client +_ugi: list -def __init__(self

Re: [PR] Fix `InMemoryCatalog` Catalog commit operation [iceberg-python]

Fokko merged PR #470: URL: https://github.com/apache/iceberg-python/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502705557 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502719019 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] enable set hadoop ugi for hive catalog [iceberg-python]

j7nhai commented on PR #472: URL: https://github.com/apache/iceberg-python/pull/472#issuecomment-1964326603 > @j7nhai this change seems reasonable to me. Can you check the type annotations? updated. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Allow non-string typed values in table properties [iceberg-python]

Fokko commented on code in PR #469: URL: https://github.com/apache/iceberg-python/pull/469#discussion_r1502723574 ## pyiceberg/table/metadata.py: ## @@ -178,6 +178,12 @@ class TableMetadataCommonFields(IcebergBaseModel): to be used for arbitrary metadata. For example, commi

Re: [PR] Spark 3.4: Include catalog name in view errors [iceberg]

nastra merged PR #9810: URL: https://github.com/apache/iceberg/pull/9810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Make CatalogHandlers.commit public [iceberg]

nastra commented on PR #9789: URL: https://github.com/apache/iceberg/pull/9789#issuecomment-1964365614 @N-o-Z can you elaborate please what exactly you're trying to achieve? Are you trying to implement multi-table commits on the server? For `COMMIT_TRANSACTION` the approach is very sim

Re: [PR] Core: Make CatalogHandlers.commit public [iceberg]

N-o-Z commented on PR #9789: URL: https://github.com/apache/iceberg/pull/9789#issuecomment-1964374624 > @N-o-Z can you elaborate please what exactly you're trying to achieve? Are you trying to implement multi-table commits on the server? For `COMMIT_TRANSACTION` the approach is very simplis

Re: [I] EMR 6.10.0 Cannot migrate a table from a non-Iceberg Spark Session Catalog. Found spark_catalog [iceberg]

wstevenson-r7 commented on issue #7317: URL: https://github.com/apache/iceberg/issues/7317#issuecomment-1964454910 For what it's worth I see the same issue with `snapshot`, any progress on this? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Writing Equality Deletes using Iceberg Java API [iceberg]

robinsinghstudios commented on issue #9808: URL: https://github.com/apache/iceberg/issues/9808#issuecomment-1964530610 > @robinsinghstudios i have done [similar implementation here ](https://github.com/memiiso/debezium-server-iceberg/tree/master/debezium-server-iceberg-sink/src/main/java/io/

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

amogh-jahagirdar commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1502940098 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1456,6 +1456,43 @@ public void showViews() throws NoSuc

[PR] [Bug Fix] cast None `current-snapshot-id` as -1 for Backwards Compatibility [iceberg-python]

syun64 opened a new pull request, #473: URL: https://github.com/apache/iceberg-python/pull/473 The existing PyIceberg `cleanup_snapshot_id` validator creates tables that are not backward compatible. On table creation, the existing behavior in Java is to create tables with current_sna

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

amogh-jahagirdar commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503057978 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Ar

Re: [PR] OpenAPI: Add ContentFile types to spec for scan and append api [iceberg]

jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1503083082 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3348,217 @@ components: type: integer format: int64 +BooleanTypeValue: + type

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

jackye1995 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503094756 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -356,6 +356,16 @@ public class S3FileIOProperties implements Serializable { public

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

jackye1995 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503096129 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Argument

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503103822 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -356,6 +356,16 @@ public class S3FileIOProperties implements Serializable { p

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

nastra commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503123700 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1456,6 +1456,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Kafka Connect: Record converters and delta writers [iceberg]

fqaiser94 commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1502911936 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Make issued_token_type optional to support OAuth2 Client Credential Flow [iceberg-python]

flyrain commented on code in PR #466: URL: https://github.com/apache/iceberg-python/pull/466#discussion_r1503212827 ## pyiceberg/catalog/rest.py: ## @@ -157,7 +157,7 @@ class TokenResponse(IcebergBaseModel): access_token: str = Field() token_type: str = Field() ex

Re: [PR] Make issued_token_type optional to support OAuth2 Client Credential Flow [iceberg-python]

flyrain commented on code in PR #466: URL: https://github.com/apache/iceberg-python/pull/466#discussion_r1503212827 ## pyiceberg/catalog/rest.py: ## @@ -157,7 +157,7 @@ class TokenResponse(IcebergBaseModel): access_token: str = Field() token_type: str = Field() ex

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

geruh commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503279807 ## docs/docs/aws.md: ## @@ -500,6 +500,13 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Access Gran

Re: [PR] feat(FileScanTask): partial execute impl for parquet [iceberg-rust]

sdd commented on PR #207: URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1965420027 Thanks for those links, Renjie, they were very useful.. I've taken a deeper look at `ArrowReader` and the python code. I'll submit an improved design here tomorrow morning (UK) with some `

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1503400947 ## format/spec.md: ## @@ -1134,10 +1148,9 @@ In some cases partition specs are stored using only the field list instead of th The `field-id` property was added fo

Re: [PR] OpenAPI: Add ContentFile types to spec for scan and append api [iceberg]

geruh commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1503405472 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3324,279 @@ components: type: integer format: int64 +BooleanTypeValue: + type: boo

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

rdblue commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503407151 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

rdblue commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503408071 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

rdblue commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503408646 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

rdblue commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503408840 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spark 3.4, 3.5: Use current namespace for SHOW VIEWS cmd [iceberg]

rdblue commented on code in PR #9787: URL: https://github.com/apache/iceberg/pull/9787#discussion_r1503409864 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1335,6 +1335,43 @@ public void showViews() throws NoSuchTableExce

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1503431015 ## format/spec.md: ## @@ -1170,9 +1170,9 @@ Each sort field in the fields list is stored as an object with the following pro | required | required | required | **`dire

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

rdblue merged PR #9661: URL: https://github.com/apache/iceberg/pull/9661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1503432867 ## format/spec.md: ## @@ -1170,9 +1170,9 @@ Each sort field in the fields list is stored as an object with the following pro | required | required | required | **`dire

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

rdblue commented on PR #9661: URL: https://github.com/apache/iceberg/pull/9661#issuecomment-1965505699 Merging this. Thanks, @szehon-ho! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] OpenAPI: Add ContentFile types to spec for scan and append api [iceberg]

rdblue commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1503435600 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3324,279 @@ components: type: integer format: int64 +BooleanTypeValue: + type: bo

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1503456330 ## format/spec.md: ## @@ -1170,9 +1170,9 @@ Each sort field in the fields list is stored as an object with the following pro | required | required | required | **`d

Re: [I] [ErrorProne] Fix outstanding error prone warnings of type NarrowingCompoundAssignment. [iceberg]

github-actions[bot] closed issue #1290: [ErrorProne] Fix outstanding error prone warnings of type NarrowingCompoundAssignment. URL: https://github.com/apache/iceberg/issues/1290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [ErrorProne] Fix outstanding error prone warnings of type NarrowingCompoundAssignment. [iceberg]

github-actions[bot] commented on issue #1290: URL: https://github.com/apache/iceberg/issues/1290#issuecomment-1965558537 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] [ErrorProne] Fix outstanding error prone warnings of type UnusedVariable. [iceberg]

github-actions[bot] closed issue #1291: [ErrorProne] Fix outstanding error prone warnings of type UnusedVariable. URL: https://github.com/apache/iceberg/issues/1291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [ErrorProne] Fix outstanding error prone warnings of type UnusedVariable. [iceberg]

github-actions[bot] commented on issue #1291: URL: https://github.com/apache/iceberg/issues/1291#issuecomment-1965558596 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Should we consider adding a github action to lint YAML files for correctness / proper style? [iceberg]

github-actions[bot] closed issue #1300: Should we consider adding a github action to lint YAML files for correctness / proper style? URL: https://github.com/apache/iceberg/issues/1300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] Should we consider adding a github action to lint YAML files for correctness / proper style? [iceberg]

github-actions[bot] commented on issue #1300: URL: https://github.com/apache/iceberg/issues/1300#issuecomment-1965558661 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Capture the template parameter in the tests for TestIcebergInputFormat#Factory [iceberg]

github-actions[bot] commented on issue #1542: URL: https://github.com/apache/iceberg/issues/1542#issuecomment-1965558992 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] numBuckets can cause division by zero [iceberg]

github-actions[bot] commented on issue #1543: URL: https://github.com/apache/iceberg/issues/1543#issuecomment-1965559058 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

  1   2   >