elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1502261145
########## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ########## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { ArgumentCaptor.forClass(S3Configuration.class); Mockito.doReturn(mockA).when(mockA).dualstackEnabled(Mockito.anyBoolean()); + Mockito.doReturn(mockA).when(mockA).crossRegionAccessEnabled(Mockito.anyBoolean()); Review Comment: @nastra `crossRegionAccessEnabled` is an `S3Client` attribute rather than `S3Configuration` (same as `dualstackEnabled`). Similar to `dualstackEnabled` attribute (not asserted in this test method), `s3Configuration.crossRegionAccessEnabled()` does not exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org