Fokko commented on code in PR #472: URL: https://github.com/apache/iceberg-python/pull/472#discussion_r1502712949
########## pyiceberg/catalog/hive.py: ########## @@ -130,17 +130,22 @@ class _HiveClient: _transport: TTransport _client: Client + _ugi: list - def __init__(self, uri: str): + def __init__(self, uri: str, ugi: str = None): Review Comment: ```suggestion def __init__(self, uri: str, ugi: Optional[str] = None): ``` ########## pyiceberg/catalog/hive.py: ########## @@ -130,17 +130,22 @@ class _HiveClient: _transport: TTransport _client: Client + _ugi: list Review Comment: ```suggestion _ugi: Optional[List[str]] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org