nastra commented on code in PR #9790:
URL: https://github.com/apache/iceberg/pull/9790#discussion_r1502421258
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -204,46 +198,44 @@ public void testPartitionedTable() throws Exception {
// Check data files table
List<Record> expectedDataFiles =
expectedEntries(table, FileContent.DATA, entriesTableSchema,
expectedDataManifests, "a");
- Assert.assertEquals("Should have one data file manifest entry", 1,
expectedDataFiles.size());
+ assertThat(expectedDataFiles).as("Should have one data file manifest
entry").hasSize(1);
Dataset<Row> actualDataFilesDs =
spark.sql("SELECT * FROM " + tableName + ".data_files " + "WHERE
partition.data='a'");
List<Row> actualDataFiles =
TestHelpers.selectNonDerived(actualDataFilesDs).collectAsList();
- Assert.assertEquals("Metadata table should return one data file", 1,
actualDataFiles.size());
+ assertThat(actualDataFiles).as("Metadata table should return one data
file").hasSize(1);
TestHelpers.assertEqualsSafe(
TestHelpers.nonDerivedSchema(actualDataFilesDs),
expectedDataFiles.get(0),
actualDataFiles.get(0));
List<Row> actualPartitionsWithProjection =
spark.sql("SELECT file_count FROM " + tableName + ".partitions
").collectAsList();
- Assert.assertEquals(
- "Metadata table should return two partitions record",
- 2,
- actualPartitionsWithProjection.size());
- for (int i = 0; i < 2; ++i) {
- Assert.assertEquals(1, actualPartitionsWithProjection.get(i).get(0));
- }
+ assertThat(actualPartitionsWithProjection)
+ .as("Metadata table should return two partitions record")
+ .hasSize(2);
+ assertThat(actualPartitionsWithProjection)
Review Comment:
```suggestion
```
this can be just comined with the statement above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
