amogh-jahagirdar commented on code in PR #9804:
URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503057978
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java:
##########
@@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() {
ArgumentCaptor.forClass(S3Configuration.class);
Mockito.doReturn(mockA).when(mockA).dualstackEnabled(Mockito.anyBoolean());
+
Mockito.doReturn(mockA).when(mockA).crossRegionAccessEnabled(Mockito.anyBoolean());
Review Comment:
Yeah unfortunately I think getting the value of the attributes from the
client isn't possible without doing some reflection hacks.
What I think we can do is add S3 integration tests though to verify the
actual cross region access behavior. That seems like a more useful test to
verify that when the property is set we can perform operations across regions
as expected. cc @jackye1995 @geruh @rahil-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
