nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502443431
########## data/src/test/java/org/apache/iceberg/data/DataTest.java: ########## @@ -31,7 +32,8 @@ import org.apache.iceberg.types.Types.MapType; import org.apache.iceberg.types.Types.StructType; import org.junit.Rule; -import org.junit.Test; +import org.junit.jupiter.api.Test; Review Comment: this class can only be switched to JUnit5 once all of its subclasses are on JUnit5. I see that there are still a few JUnit4 ones in `iceberg-flink`that would need to be converted first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
