Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990998684 ## azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java: ## @@ -71,6 +78,49 @@ public void testWithSasToken() { verify(clientBuilder, never()).c

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1991831422 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProviderTest.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1991836859 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProviderTest.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990998684 ## azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java: ## @@ -71,6 +78,49 @@ public void testWithSasToken() { verify(clientBuilder, never()).c

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990951307 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990946520 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2717171425 @ChaladiMohanVamsi thanks for working on this. I did another pass and added some comments. I still need to review the tests in detail -- This is an automated message from the Apache Gi

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1991004753 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/BaseVendedCredentialsTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990998684 ## azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java: ## @@ -71,6 +78,49 @@ public void testWithSasToken() { verify(clientBuilder, never()).c

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r199179 ## azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java: ## @@ -71,6 +78,49 @@ public void testWithSasToken() { verify(clientBuilder, never()).c

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990990450 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990989390 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990988002 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990976397 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990974582 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990947089 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990960907 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990952602 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990951307 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990929183 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1986138213 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1958006541 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1958006541 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1957988027 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1952231561 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1920173884 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

adutra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1919880274 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

danielcweeks commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1919375030 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

danielcweeks commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1919339530 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2592109791 @ChaladiMohanVamsi can you please make sure that the same improvements from https://github.com/apache/iceberg/pull/11954 are also applied here? -- This is an automated message from the

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

danielcweeks commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1915252528 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProviderTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1894643565 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886977070 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886971501 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886935941 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886799810 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2543179537 > @ChaladiMohanVamsi Can you help to understand how you would initialize ADLSFileIO with these changes. Priorly we can call initialize with the SAS token or account key and in

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1885113791 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -90,7 +117,9 @@ public Optional adlsWriteBlockSize() { */ public void app

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1885113085 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1885093076 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1885090402 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ShyamalaGowri commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2541761879 @ChaladiMohanVamsi Can you help to understand how you would initialize ADLSFileIO with these changes. Priorly we can call initialize with the SAS token or account key and initiali

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881530121 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881528468 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2538047119 @danielcweeks could you also take a look at this PR please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881537532 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881531755 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881533944 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881531528 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881531305 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881527842 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -90,7 +117,9 @@ public Optional adlsWriteBlockSize() { */ public void applyClientCon

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2522804342 @nastra @amogh-jahagirdar Thanks for the review and suggestions. I have addressed the review comments. I was able to test the credentials refresh logic in ADLS environme

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1873006517 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProviderTest.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1872968837 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1872975746 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1872969519 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1872949411 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -67,6 +83,16 @@ public AzureProperties(Map properties) { if (properties.con

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2514171444 @ChaladiMohanVamsi thanks for working on this. Do you have a way of actually testing this PR with an ADLS environment and see whether the refreshes work? -- This is an automated messag

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867465906 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProviderTest.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867457827 ## azure/src/test/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProviderTest.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867457306 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867454171 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867451227 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867447807 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Op

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867429049 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867428213 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867416416 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867409678 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -67,6 +83,16 @@ public AzureProperties(Map properties) { if (properties.containsKey(AD

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867402766 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Op

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867400944 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Op

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867399820 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Op

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867398362 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Op

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862580698 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862577329 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862575461 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862575184 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862574536 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1862573721 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

amogh-jahagirdar commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1854001589 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ChaladiMohanVamsi commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2482829488 cc// @nastra @jackye1995 @amogh-jahagirdar @munendrasn Can you please help with the review. -- This is an automated message from the Apache Git Service. To respond to the me