nastra commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990998684


##########
azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java:
##########
@@ -71,6 +78,49 @@ public void testWithSasToken() {
     verify(clientBuilder, 
never()).credential(any(StorageSharedKeyCredential.class));
   }
 
+  @Test
+  public void testWithRefreshCredentialsEndpoint() {
+    try (var providerMockedConstruction = 
mockConstruction(VendedAdlsCredentialProvider.class);

Review Comment:
   I'd suggest to give all of these some normal names, such as 
`credendialProvider` instead of `providerMockedConstruction`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to