nastra commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867399820
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -25,24 +25,40 @@
import java.util.Collections;
import java.util.Map;
import java.util.Optional;
+import org.apache.iceberg.azure.adlsv2.VendedAzureSasCredentialProvider;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.base.Strings;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.util.PropertyUtil;
public class AzureProperties implements Serializable {
public static final String ADLS_SAS_TOKEN_PREFIX = "adls.sas-token.";
+ public static final String ADLS_SAS_TOKEN_EXPIRE_AT_MS_PREFIX =
"adls.sas-token-expire-at-ms.";
public static final String ADLS_CONNECTION_STRING_PREFIX =
"adls.connection-string.";
public static final String ADLS_READ_BLOCK_SIZE =
"adls.read.block-size-bytes";
public static final String ADLS_WRITE_BLOCK_SIZE =
"adls.write.block-size-bytes";
public static final String ADLS_SHARED_KEY_ACCOUNT_NAME =
"adls.auth.shared-key.account.name";
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+ /**
+ * When set, the {@link
org.apache.iceberg.azure.adlsv2.VendedAzureSasCredentialProvider} will be
+ * used to fetch and refresh vended credentials from this endpoint.
+ */
+ public static final String REFRESH_CREDENTIALS_ENDPOINT =
"client.refresh-credentials-endpoint";
Review Comment:
```suggestion
public static final String ADLS_REFRESH_CREDENTIALS_ENDPOINT =
"adls.refresh-credentials-endpoint";
```
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -25,24 +25,40 @@
import java.util.Collections;
import java.util.Map;
import java.util.Optional;
+import org.apache.iceberg.azure.adlsv2.VendedAzureSasCredentialProvider;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.base.Strings;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.util.PropertyUtil;
public class AzureProperties implements Serializable {
public static final String ADLS_SAS_TOKEN_PREFIX = "adls.sas-token.";
+ public static final String ADLS_SAS_TOKEN_EXPIRE_AT_MS_PREFIX =
"adls.sas-token-expire-at-ms.";
public static final String ADLS_CONNECTION_STRING_PREFIX =
"adls.connection-string.";
public static final String ADLS_READ_BLOCK_SIZE =
"adls.read.block-size-bytes";
public static final String ADLS_WRITE_BLOCK_SIZE =
"adls.write.block-size-bytes";
public static final String ADLS_SHARED_KEY_ACCOUNT_NAME =
"adls.auth.shared-key.account.name";
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+ /**
+ * When set, the {@link
org.apache.iceberg.azure.adlsv2.VendedAzureSasCredentialProvider} will be
+ * used to fetch and refresh vended credentials from this endpoint.
+ */
+ public static final String REFRESH_CREDENTIALS_ENDPOINT =
"client.refresh-credentials-endpoint";
Review Comment:
this should have a `adls` prefix instead of `client`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
