nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1990990450
########## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.azure.adlsv2; + +import com.azure.core.credential.AzureSasCredential; +import com.azure.core.http.HttpPipelineCallContext; +import com.azure.core.http.HttpPipelineNextPolicy; +import com.azure.core.http.HttpPipelineNextSyncPolicy; +import com.azure.core.http.HttpResponse; +import com.azure.core.http.policy.AzureSasCredentialPolicy; +import com.azure.core.http.policy.HttpPipelinePolicy; +import java.util.Objects; +import reactor.core.publisher.Mono; + +public class VendedAzureSasCredentialPolicy implements HttpPipelinePolicy { + private final String account; + private final VendedAdlsCredentialProvider vendedAdlsCredentialProvider; + private AzureSasCredential azureSasCredential; + private AzureSasCredentialPolicy azureSasCredentialPolicy; + + public VendedAzureSasCredentialPolicy( + String account, VendedAdlsCredentialProvider vendedAdlsCredentialProvider) { + this.account = account; + this.vendedAdlsCredentialProvider = vendedAdlsCredentialProvider; + } + + @Override + public Mono<HttpResponse> process( + HttpPipelineCallContext httpPipelineCallContext, + HttpPipelineNextPolicy httpPipelineNextPolicy) { + updateAzureSasCredential(); + return azureSasCredentialPolicy.process(httpPipelineCallContext, httpPipelineNextPolicy); + } + + @Override + public HttpResponse processSync( + HttpPipelineCallContext context, HttpPipelineNextSyncPolicy next) { + updateAzureSasCredential(); + return azureSasCredentialPolicy.processSync(context, next); + } + + private void updateAzureSasCredential() { + String sasToken = vendedAdlsCredentialProvider.credentialForAccount(account); + if (Objects.isNull(azureSasCredential)) { + azureSasCredential = new AzureSasCredential(sasToken); Review Comment: ```suggestion this.azureSasCredential = new AzureSasCredential(sasToken); ``` ########## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.azure.adlsv2; + +import com.azure.core.credential.AzureSasCredential; +import com.azure.core.http.HttpPipelineCallContext; +import com.azure.core.http.HttpPipelineNextPolicy; +import com.azure.core.http.HttpPipelineNextSyncPolicy; +import com.azure.core.http.HttpResponse; +import com.azure.core.http.policy.AzureSasCredentialPolicy; +import com.azure.core.http.policy.HttpPipelinePolicy; +import java.util.Objects; +import reactor.core.publisher.Mono; + +public class VendedAzureSasCredentialPolicy implements HttpPipelinePolicy { + private final String account; + private final VendedAdlsCredentialProvider vendedAdlsCredentialProvider; + private AzureSasCredential azureSasCredential; + private AzureSasCredentialPolicy azureSasCredentialPolicy; + + public VendedAzureSasCredentialPolicy( + String account, VendedAdlsCredentialProvider vendedAdlsCredentialProvider) { + this.account = account; + this.vendedAdlsCredentialProvider = vendedAdlsCredentialProvider; + } + + @Override + public Mono<HttpResponse> process( + HttpPipelineCallContext httpPipelineCallContext, + HttpPipelineNextPolicy httpPipelineNextPolicy) { + updateAzureSasCredential(); + return azureSasCredentialPolicy.process(httpPipelineCallContext, httpPipelineNextPolicy); + } + + @Override + public HttpResponse processSync( + HttpPipelineCallContext context, HttpPipelineNextSyncPolicy next) { + updateAzureSasCredential(); + return azureSasCredentialPolicy.processSync(context, next); + } + + private void updateAzureSasCredential() { + String sasToken = vendedAdlsCredentialProvider.credentialForAccount(account); + if (Objects.isNull(azureSasCredential)) { + azureSasCredential = new AzureSasCredential(sasToken); + azureSasCredentialPolicy = new AzureSasCredentialPolicy(azureSasCredential, false); Review Comment: ```suggestion this.azureSasCredentialPolicy = new AzureSasCredentialPolicy(azureSasCredential, false); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
