ChaladiMohanVamsi commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r1885113791
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -90,7 +117,9 @@ public Optional<Long> adlsWriteBlockSize() {
*/
public void applyClientConfiguration(String account,
DataLakeFileSystemClientBuilder builder) {
String sasToken = adlsSasTokens.get(account);
- if (sasToken != null && !sasToken.isEmpty()) {
+ if (adlsRefreshCredentialsEnabled &&
!Strings.isNullOrEmpty(adlsRefreshCredentialsEndpoint)) {
Review Comment:
Yes, that simplifies the check. Changed as per the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
