ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1952231561
########## azure/src/main/java/org/apache/iceberg/azure/adlsv2/AzureSasCredentialRefresher.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.azure.adlsv2; + +import com.azure.core.credential.AzureSasCredential; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; +import java.util.function.Supplier; +import org.apache.iceberg.util.Pair; + +class AzureSasCredentialRefresher { + private final Supplier<Pair<String, Long>> sasTokenWithExpirationSupplier; Review Comment: While exploring the possibility of using `AccessToken` and `SimpleTokenCache` I observed below things. @danielcweeks @nastra Please share your inputs on next steps and pointers if I am missing anything from above suggestions. 1. Technically we can replace `Pair<>` with `AccessToken` which includes token and expiration, it seems from the Azure library conventions `AccessToken` is used as part of OAuth authentication and always ends up as bearer token in request headers. Where as in the current implementation we are dealing with `SAS token`, which needs to be appended to request URI instead of headers. 1. Want to confirm if we are introducing any confusion by using AccessToken in this context before making the change. 2. Though `SimpleTokenCache` has the logic to handle expiration when we call getToken(), I don't see a way to inject `SimpleTokenCache` into `AzureSasCredential`, which is a final class and there is no alternative to send SASToken credential to `DataLakeFileSystemClientBuilder` other than `AzureSasCredential`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
