nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1867447807
########## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ########## @@ -25,24 +25,40 @@ import java.util.Collections; import java.util.Map; import java.util.Optional; +import org.apache.iceberg.azure.adlsv2.VendedAzureSasCredentialProvider; import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.base.Strings; import org.apache.iceberg.relocated.com.google.common.collect.Maps; import org.apache.iceberg.util.PropertyUtil; public class AzureProperties implements Serializable { public static final String ADLS_SAS_TOKEN_PREFIX = "adls.sas-token."; + public static final String ADLS_SAS_TOKEN_EXPIRE_AT_MS_PREFIX = "adls.sas-token-expire-at-ms."; Review Comment: ```suggestion public static final String ADLS_SAS_TOKEN_EXPIRES_AT_MS_PREFIX = "adls.sas-token-expires-at-ms."; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org