Fokko commented on PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#issuecomment-2538644674
Let's move this forward, thanks everyone for chiming in here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Fokko merged PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1881257096
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879660010
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877883560
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877769090
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877805402
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
raulcd commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877791436
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
Fokko commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877784467
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distr
Fokko commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877784467
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distr
Fokko commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877784467
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distr
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877780728
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877496017
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877009126
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
raulcd commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1876323203
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1876012541
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1876012541
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875994185
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875980038
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875923329
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875912691
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875912691
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1875902086
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874597692
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
Fokko commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874545852
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distr
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874500601
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874499101
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
pre-commit or cpp-linter-action will be integrate
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874358635
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873677036
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873639268
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
raulcd commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873469974
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I am not familiar with the `cpp-linter-action` or t
wgtmac commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873449223
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I don't think they are blockers at this moment. Eve
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873444269
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I agree we should have a pre-commit file and Githu
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873436117
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
wgtmac commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873409074
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Can we integrate a Github action like
https://gith
wgtmac commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873409074
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Can we integrate a Github action like
https://gith
wgtmac commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873402979
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873276234
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
How about adding a pre-commit file?
--
This is
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873276006
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873181572
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could you add some instructions into the READM
43 matches
Mail list logo
