raulcd commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873469974


##########
.clang-format:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   I am not familiar with the `cpp-linter-action` or the `clang-format-action` 
but they don't seem complex to integrate. At Arrow we use pre-commit as 
suggested by @pitrou .
   
   https://github.com/apache/arrow/blob/main/.pre-commit-config.yaml#L61-L101
   
   https://github.com/apache/arrow/blob/main/.github/workflows/dev.yml#L43-L67
   
   I am happy to integrate any, should be pretty straight forward once we agree 
on a configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to