wgtmac commented on code in PR #4: URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1873409074
########## .clang-format: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Can we integrate a Github action like https://github.com/cpp-linter/cpp-linter-action? FYI I have filed an INFRA JIRA to whitelist it but it seems not resolved yet: https://issues.apache.org/jira/browse/INFRA-26318 I have also added a C++ format check via Github action: https://github.com/apache/orc/blob/d7d6924de13fcbf938d953935b81949593969f12/.github/workflows/build_and_test.yml#L161-L176 But I'm in favor of `cpp-linter/cpp-linter-action` above. cc @raulcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
