zhjwpku commented on code in PR #4: URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
########## .clang-format: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +BasedOnStyle: Google +ColumnLimit: 90 +DerivePointerAlignment: false +IncludeBlocks: Preserve Review Comment: I plan to make the following changes after we reached a consensus. ``` -IncludeBlocks: Preserve +IncludeBlocks: Regroup +IncludeCategories: +- Regex: '^<.*/' # Like <boost/lexical_cast.hpp> + Priority: 3 +- Regex: '^<.*\.' # Like <fcntl.h> + Priority: 1 +- Regex: '^<' # Like <vector> + Priority: 2 +- Regex: '^"' # Like "util/auth-util.h" + Priority: 4 ``` Before I push a new commit, I'd like to explain why I think this makes sense. I did a experiment, `Regroup` seems to be the default setting if we don't specify a `IncludeBlocks` setting, I put it here explicitly because I think it's more clear for the readers. With the `IncludeCategories` settings, the following: ``` #include <iostream> #include <string> #include <boost/lexical_cast.hpp> #include "util/auth-util.h" #include <vector> #include <fcntl.h> #include "demo_table.h" ``` goes to: ``` #include "demo_table.h" #include <fcntl.h> #include <iostream> #include <string> #include <vector> #include <boost/lexical_cast.hpp> #include "util/auth-util.h" ``` It's slightly different from Impala's setting because I think putting the `Regex` as the first line of each rule is more readable, "If match this regex, then goes priority xxx". What do you think about this proposal? @gaborkaszab @pitrou @Fokko @wgtmac @raulcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
