Fokko commented on code in PR #4: URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877784467
########## .clang-format: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +BasedOnStyle: Google +ColumnLimit: 90 Review Comment: In the Iceberg community, we try to be consensus-driven. Here it is important to have a conversation _about why_ anyone thinks it should be 90, 100, or something else, so we understand each others' reasoning and potential concerns. Neither shutting down a discussion by closing a comment, or jumping to a vote is not helping to reach that, and is hopefully not needed because it adds procedure. I think, just pointing to other projects is not a strong argument, because it might be like that for historical reasons. When starting a new project, it is a good moment to reconsider some of the decisions made in the past. We try to reach a state where everyone can live with the decision being made, give their approval, and move forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
