zhjwpku commented on code in PR #4: URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1874597692
########## .clang-format: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +BasedOnStyle: Google +ColumnLimit: 90 Review Comment: > I'll leave this here: https://github.com/apache/iceberg-python/blob/1c73b7c97d8db5e76dd34e57debee3753439f0eb/pyproject.toml#L915 > > However, it is language-specific. I don't find any issues with reviewing PRs with longer-length lines, but I think it is similar to what you're used to. Agree, I just pushed a commit that make clang-format language-specific, now the rules only effect C++ source code. Interestingly the ORC project has `ColumnLimit: 100`, it's not only language-specific but also project-specific, so I suggest we use `ColumnLimit: 90` for now and do some change when we find it's not proper later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
