rdblue commented on PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#issuecomment-2702257228
Thanks for the reviews, @danielcweeks and @aihuaxu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
danielcweeks merged PR #12323:
URL: https://github.com/apache/iceberg/pull/12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980618098
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980265501
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980243819
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
danielcweeks commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980214339
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -192,6 +194,11 @@ public WriteBuilder schema(Schema newSchema) {
return this;
danielcweeks commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980212065
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1976216730
##
core/src/main/java/org/apache/iceberg/variants/VariantVisitor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1976219383
##
parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java:
##
@@ -56,6 +58,19 @@ public class TypeToMessageType {
LogicalTypeAnnotation.timesta
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1976217430
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1976217154
##
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##
@@ -157,6 +171,16 @@ public ParquetValueWriter primitive(PrimitiveType
primitive)
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1973887545
##
core/src/main/java/org/apache/iceberg/variants/VariantVisitor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aihuaxu commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1972563111
##
core/src/main/java/org/apache/iceberg/variants/VariantVisitor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
rdblue commented on PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#issuecomment-2675805303
Rebased after moving variants to API in #12374.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rdblue closed pull request #12323: Parquet: Implement Variant writers
URL: https://github.com/apache/iceberg/pull/12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964585019
##
core/src/main/java/org/apache/iceberg/variants/VariantData.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964509422
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##
@@ -71,6 +71,10 @@ public static UnboxedWriter shorts(ColumnDescriptor
desc) {
r
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964508977
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964508538
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -192,6 +194,11 @@ public WriteBuilder schema(Schema newSchema) {
return this;
}
+
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964506375
##
core/src/main/java/org/apache/iceberg/variants/Variants.java:
##
@@ -85,6 +85,16 @@ public static ShreddedObject object(VariantMetadata
metadata) {
return new
rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964507242
##
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##
@@ -62,7 +71,7 @@ protected ParquetValueWriter
timestampWriter(ColumnDescriptor de
21 matches
Mail list logo
