rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1976217154
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##########
@@ -157,6 +171,16 @@ public ParquetValueWriter<?> primitive(PrimitiveType
primitive) {
throw new UnsupportedOperationException("Unsupported type: " +
primitive);
}
}
+
+ @Override
+ public ParquetValueWriter<?> variant(Types.VariantType iVariant,
ParquetValueWriter<?> result) {
+ return result;
+ }
+
+ @Override
+ public ParquetVariantVisitor<ParquetValueWriter<?>> variantVisitor() {
Review Comment:
This is part of the Parquet visitor contract now. It needs to be public
because that class is public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
