danielcweeks commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1980214339


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -192,6 +194,11 @@ public WriteBuilder schema(Schema newSchema) {
       return this;
     }
 
+    public WriteBuilder variantShreddingFunc(BiFunction<Integer, String, Type> 
func) {

Review Comment:
   We should be documenting this, I don't think anyone will find this comment 
(see previous comment about codifying the interfaces)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to