Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra merged PR #8909: URL: https://github.com/apache/iceberg/pull/8909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422818781 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected Map

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422711943 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -448,33 +480,85 @@ public void renameTable(TableIdentifier from, TableIdentifier

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422711613 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -133,69 +114,30 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422710861 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -133,69 +114,30 @@ protected void doCommit(TableMetadata base, TableMetadata m

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422706464 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected Map p

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422658039 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -133,69 +114,30 @@ protected void doCommit(TableMetadata base, TableMetadata metada

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422656154 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422655391 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422637569 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected Map

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422637569 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected Map

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422634486 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -133,69 +114,30 @@ protected void doCommit(TableMetadata base, TableMetadata metadat

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422626565 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422622180 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422564943 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -133,69 +114,30 @@ protected void doCommit(TableMetadata base, TableMetadata metada

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422535596 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422521681 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422508540 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference( protected Map

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422497424 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -400,8 +400,15 @@ public void replaceTableViaTransactionThatAlreadyExistsAsView() {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422076161 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -239,33 +240,24 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1849458811 @nastra: Looks like https://github.com/apache/iceberg/pull/9012 is causing test failure for this PR after rebase. I tried fixing at Nessie side. But it opens up another issues. Pleas

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r142032 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -232,17 +232,32 @@ protected String defaultWarehouseLocation(TableIdentifier table) {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420339501 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -232,17 +232,32 @@ protected String defaultWarehouseLocation(TableIdentifier table) {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420317210 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -190,4 +203,118 @@ public static Optional extractSingleConflict( Conflict conflict = confli

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420232303 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -190,4 +203,118 @@ public static Optional extractSingleConflict( Conflict conflict = confli

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420230637 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -142,15 +148,27 @@ private UpdateableReference loadReference(String requestedRef, Stri

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420229851 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -142,15 +148,27 @@ private UpdateableReference loadReference(String requestedRef

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420226948 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -190,4 +203,118 @@ public static Optional extractSingleConflict( Conflict conflict =

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r142062 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -142,15 +148,27 @@ private UpdateableReference loadReference(String requestedRef

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420215532 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -190,4 +203,118 @@ public static Optional extractSingleConflict( Conflict conflict = confli

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1846896443 @nastra: I have addressed the comments. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420212153 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -142,15 +148,27 @@ private UpdateableReference loadReference(String requestedRef, Stri

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420210944 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420006288 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419995071 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -267,4 +305,23 @@ static DataFile makeDataFile(Table icebergTable, String fileLocati

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419970848 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -141,16 +147,26 @@ private UpdateableReference loadReference(String requestedRef

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419953116 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -141,16 +147,26 @@ private UpdateableReference loadReference(String requestedRef

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419122432 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419093010 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419095071 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419092132 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419091171 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419090042 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419093588 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419087834 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419086031 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419083813 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419087100 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieView.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419080356 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419081069 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419078008 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419073781 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -267,4 +305,23 @@ static DataFile makeDataFile(Table icebergTable, String fileLocation) {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419075510 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -180,6 +188,32 @@ protected Table createTable(TableIdentifier tableIdentifier, Schema sche

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419074476 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -180,6 +188,32 @@ protected Table createTable(TableIdentifier tableIdentifier, Schema sche

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419065698 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -141,16 +147,26 @@ private UpdateableReference loadReference(String requestedRef, Stri

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419059002 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -448,33 +473,82 @@ public void renameTable(TableIdentifier from, TableIdentifier to) {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1845247046 Note: I am squashing the commits into one (since I am having hard time rebasing with 8 commits). -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1845096677 @snazy, @nastra: If this PR is ok. Can I get an approval? If not, what more changes are expected? I thought of waiting for https://github.com/apache/iceberg/pull/8857/ an

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

dimas-b commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1417478873 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -465,8 +472,15 @@ public void replaceViewThatAlreadyExistsAsTable() { .w

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1836303934 Addressed new comments other than (https://github.com/apache/iceberg/pull/8909#discussion_r1410813198). Feel free to push the changes on top of this PR. -- This is an automated m

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1412244983 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1412241028 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -132,74 +130,42 @@ protected void doRefresh() { @Override protected voi

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1412239066 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1412237675 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -180,6 +188,33 @@ protected Table createTable(TableIdentifier tableIdentifier, Schem

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1412236654 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +327,73 @@ private TableIdentifier identifierWithoutTableReference( protected

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1410902735 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -165,4 +180,95 @@ public static TableMetadata updateTableMetadataWithNessieSpecificProper

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

snazy commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1410794852 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +327,73 @@ private TableIdentifier identifierWithoutTableReference( protected Map pr

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1831262790 PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1405536815 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -378,27 +403,71 @@ public void renameTable(TableIdentifier from, TableIdentifier

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1405528927 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -165,4 +180,95 @@ public static TableMetadata updateTableMetadataWithNessieSpecificProper

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1403134265 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -400,8 +400,15 @@ public void replaceTableViaTransactionThatAlreadyExistsAsView() {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

snazy commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1402432505 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +634,35 @@ public void close() { api.close(); } } + + public void

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1822627656 @snazy: I have addressed most of the comments and replied the reason for unhandled comments. Please take a look again. Thanks. -- This is an automated message from the Apache

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401930877 ## nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java: ## @@ -62,7 +62,7 @@ public Reference getReference() { public void checkMutable()

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401930448 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +617,72 @@ public void close() { api.close(); } } + + publ

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929783 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -378,27 +400,72 @@ public void renameTable(TableIdentifier from, TableIdentifier

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929044 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -170,11 +184,12 @@ private TableIdentifier toIdentifier(EntriesResponse.Entry en

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929044 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -170,11 +184,12 @@ private TableIdentifier toIdentifier(EntriesResponse.Entry en

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401896252 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +630,72 @@ public void close() { api.close(); } } + + publ

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401883956 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401732524 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -132,74 +130,42 @@ protected void doRefresh() { @Override protected voi

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401700626 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400604336 ## nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibilityForView.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400469049 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +630,72 @@ public void close() { api.close(); } } + + publ

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400147481 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -104,12 +96,18 @@ protected void doRefresh() { content

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400110138 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -104,12 +96,18 @@ protected void doRefresh() { content

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400108586 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400104301 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -267,4 +306,23 @@ static DataFile makeDataFile(Table icebergTable, String fileLocati

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400100247 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1399218687 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +630,72 @@ public void close() { api.close(); } } + + publ

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

snazy commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1397204876 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java: ## @@ -132,74 +130,42 @@ protected void doRefresh() { @Override protected void doCom

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1816468831 > Lots of the existing code for tables is now duplicated for views - the critical code paths should be unified. I would suggest to do those refactorings as a separate PR, otherwise

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1397340519 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

snazy commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1397151718 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -312,26 +327,32 @@ namespace, getRef().getName()), } public void renameTable(Tab

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on PR #8909: URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1809949624 Only these two comments needs conclusion. Rest of the comments are addressed. - https://github.com/apache/iceberg/pull/8909#discussion_r1374101581 - https://github.com/apac

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1389625938 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1387790517 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1387788306 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +630,72 @@ public void close() { api.close(); } } + + publ

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1387787475 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -400,8 +400,15 @@ public void replaceTableViaTransactionThatAlreadyExistsAsView() {

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

nastra commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1387752354 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -400,8 +400,15 @@ public void replaceTableViaTransactionThatAlreadyExistsAsView() {

  1   2   >