dimas-b commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1422508540
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -347,4 +339,65 @@ private TableIdentifier identifierWithoutTableReference(
protected Map<String, String> properties() {
return catalogOptions;
}
+
+ @Override
+ protected ViewOperations newViewOps(TableIdentifier identifier) {
+ TableReference tr = parseTableReference(identifier);
+ return new NessieViewOperations(
+ ContentKey.of(
+
org.projectnessie.model.Namespace.of(identifier.namespace().levels()),
tr.getName()),
+ client.withReference(tr.getReference(), tr.getHash()),
+ fileIO);
+ }
+
+ @Override
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ return client.listViews(namespace);
+ }
+
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ TableReference tableReference = parseTableReference(identifier);
+ return client
+ .withReference(tableReference.getReference(), tableReference.getHash())
+ .dropView(identifierWithoutTableReference(identifier, tableReference),
false);
+ }
+
+ @Override
+ public void renameView(TableIdentifier from, TableIdentifier to) {
+ TableReference fromTableReference = parseTableReference(from);
+ TableReference toTableReference = parseTableReference(to);
+
+ validateReferenceForRename(fromTableReference, toTableReference,
Content.Type.ICEBERG_VIEW);
+
+ TableIdentifier fromIdentifier =
+ NessieUtil.removeCatalogName(
+ identifierWithoutTableReference(from, fromTableReference), name());
+ TableIdentifier toIdentifier =
+ NessieUtil.removeCatalogName(identifierWithoutTableReference(to,
toTableReference), name());
+ client
+ .withReference(fromTableReference.getReference(),
fromTableReference.getHash())
+ .renameView(fromIdentifier, toIdentifier);
+ }
+
+ private void validateReferenceForRename(
+ TableReference fromTableReference, TableReference toTableReference,
Content.Type type) {
+ String fromReference =
+ fromTableReference.hasReference()
+ ? fromTableReference.getReference()
+ : client.getRef().getName();
+ String toReference =
+ toTableReference.hasReference()
+ ? toTableReference.getReference()
+ : client.getRef().getName();
+ Preconditions.checkArgument(
+ fromReference.equalsIgnoreCase(toReference),
+ "Cannot rename %s '%s' on reference '%s' to '%s' on reference '%s':"
+ + " source and target references must be the same.",
+ NessieUtil.contentTypeString(type).toLowerCase(),
Review Comment:
Since the expected text is in English we should use
`.toLowerCase(Locale.ENGLISH))`. Using the default locale can have surprising
results.... may be not in this particular case, but we ought to ensure
correctness in general, I think.
Try this: `assertThat("VIEW".toLowerCase(new
Locale("TR"))).isEqualTo("view");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
