ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420339501
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -232,17 +232,32 @@ protected String defaultWarehouseLocation(TableIdentifier
table) {
@Override
public List<TableIdentifier> listTables(Namespace namespace) {
- return client.listContents(namespace, Content.Type.ICEBERG_TABLE);
+ return client.listTables(namespace);
}
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
- return dropContent(identifier, Content.Type.ICEBERG_TABLE);
+ TableReference tableReference = parseTableReference(identifier);
+ return client
+ .withReference(tableReference.getReference(), tableReference.getHash())
+ .dropTable(identifierWithoutTableReference(identifier,
tableReference), false);
}
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
- renameContent(from, to, Content.Type.ICEBERG_TABLE);
+ TableReference fromTableReference = parseTableReference(from);
Review Comment:
Note: not moving these checks to a private common method as I got a comment
recently that
we should not diverge
catalog.table -> catalog.content -> client.table -> client.content
now it looks like catalog.table -> catalog.table -> client.content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
